From ceee0896ba1b13097a14480498dc6d9a25383b13 Mon Sep 17 00:00:00 2001 From: Dan Jing Date: Thu, 29 Aug 2024 11:39:35 +0800 Subject: [PATCH] [Enhancement] add metrics for analysis error(backport #50250) (#50308) Signed-off-by: jingdan Signed-off-by: Dan Jing --- .../src/main/java/com/starrocks/metric/MetricRepo.java | 10 ++++++++++ .../main/java/com/starrocks/qe/ConnectProcessor.java | 6 ++++++ 2 files changed, 16 insertions(+) diff --git a/fe/fe-core/src/main/java/com/starrocks/metric/MetricRepo.java b/fe/fe-core/src/main/java/com/starrocks/metric/MetricRepo.java index 9f4ddf99abac1..65dfb790cf6a2 100644 --- a/fe/fe-core/src/main/java/com/starrocks/metric/MetricRepo.java +++ b/fe/fe-core/src/main/java/com/starrocks/metric/MetricRepo.java @@ -114,6 +114,9 @@ public final class MetricRepo { public static LongCounterMetric COUNTER_QUERY_QUEUE_TOTAL; public static LongCounterMetric COUNTER_QUERY_QUEUE_TIMEOUT; + public static LongCounterMetric COUNTER_QUERY_ANALYSIS_ERR; + public static LongCounterMetric COUNTER_QUERY_INTERNAL_ERR; + public static LongCounterMetric COUNTER_UNFINISHED_BACKUP_JOB; public static LongCounterMetric COUNTER_UNFINISHED_RESTORE_JOB; @@ -404,6 +407,13 @@ public Long getValue() { "counter of image succeeded in pushing to other frontends"); STARROCKS_METRIC_REGISTER.addMetric(COUNTER_IMAGE_PUSH); + COUNTER_QUERY_ANALYSIS_ERR = new LongCounterMetric("query_analysis_err", MetricUnit.REQUESTS, + "total analysis error query"); + STARROCKS_METRIC_REGISTER.addMetric(COUNTER_QUERY_ANALYSIS_ERR); + COUNTER_QUERY_INTERNAL_ERR = new LongCounterMetric("query_internal_err", MetricUnit.REQUESTS, + "total internal error query"); + STARROCKS_METRIC_REGISTER.addMetric(COUNTER_QUERY_INTERNAL_ERR); + COUNTER_TXN_REJECT = new LongCounterMetric("txn_reject", MetricUnit.REQUESTS, "counter of rejected transactions"); STARROCKS_METRIC_REGISTER.addMetric(COUNTER_TXN_REJECT); diff --git a/fe/fe-core/src/main/java/com/starrocks/qe/ConnectProcessor.java b/fe/fe-core/src/main/java/com/starrocks/qe/ConnectProcessor.java index b931fa1e44420..8e58070c355ae 100644 --- a/fe/fe-core/src/main/java/com/starrocks/qe/ConnectProcessor.java +++ b/fe/fe-core/src/main/java/com/starrocks/qe/ConnectProcessor.java @@ -197,6 +197,12 @@ public void auditAfterExec(String origStmt, StatementBase parsedStmt, PQueryStat MetricRepo.COUNTER_QUERY_ERR.increase(1L); ResourceGroupMetricMgr.increaseQueryErr(ctx, 1L); ctx.getAuditEventBuilder().setDigest(computeStatementDigest(parsedStmt)); + //represent analysis err + if (ctx.getState().getErrType() == QueryState.ErrType.ANALYSIS_ERR) { + MetricRepo.COUNTER_QUERY_ANALYSIS_ERR.increase(1L); + } else { + MetricRepo.COUNTER_QUERY_INTERNAL_ERR.increase(1L); + } } else { // ok query MetricRepo.COUNTER_QUERY_SUCCESS.increase(1L);