[BP-1232] Connectionpool blacklist #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom repeated query attempts to a domain we can't reach
|
Commenting generically here as well - please rename this feature to "Exclusion list" or "Excluded list". |
zinic
reviewed
Jan 9, 2025
AD7ZJ
approved these changes
Jan 9, 2025
rvazarkar
approved these changes
Jan 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add domain blacklist to LdapConnectionPool to try to alleviate pain from repeated query attempts to a domain we can't reach.
Motivation and Context
https://specterops.atlassian.net/browse/BP-1232
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: