Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial NTLM Implementation #177

Open
wants to merge 8 commits into
base: v4
Choose a base branch
from
Open

Initial NTLM Implementation #177

wants to merge 8 commits into from

Conversation

rvazarkar
Copy link
Contributor

Description

This is the initial implementation of the new NTLM modelling, courtesy of @leechristensen .

Motivation and Context

https://specterops.atlassian.net/browse/BED-5113

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

mvlipka
mvlipka requested changes Dec 9, 2024
View reviewed changes
Copy link

@mvlipka mvlipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, mostly style comments and naming conventions that I think we can improve on

src/CommonLib/OutputTypes/APIResult.cs Outdated Show resolved Hide resolved
src/CommonLib/OutputTypes/NtlmSession.cs Show resolved Hide resolved
src/CommonLib/OutputTypes/NtlmSession.cs Show resolved Hide resolved
src/CommonLib/OutputTypes/NtlmSession.cs Outdated Show resolved Hide resolved
src/CommonLib/OutputTypes/NtlmSession.cs Outdated Show resolved Hide resolved
src/CommonLib/ThirdParty/PSOpenAD/Authentication.cs Show resolved Hide resolved
src/CommonLib/ThirdParty/PSOpenAD/SSPI.cs Outdated Show resolved Hide resolved
src/CommonLib/ThirdParty/PSOpenAD/SSPI.cs Outdated Show resolved Hide resolved
src/CommonLib/Ntlm/LdapNative.cs Show resolved Hide resolved
src/CommonLib/ThirdParty/PSOpenAD/SSPI.cs Show resolved Hide resolved
@rvazarkar
Copy link
Contributor Author

recheck

@rvazarkar rvazarkar requested a review from mvlipka January 8, 2025 19:02
@rvazarkar rvazarkar changed the title WIP: NTLM Implementation Initial NTLM Implementation Jan 8, 2025
@rvazarkar
Merge branch 'v4' into ntlm
40aa72c 
# Conflicts:
#	src/CommonLib/LdapConnectionPool.cs
@rvazarkar
chore: clean up some bad comments
9d230ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leechristensen leechristensen leechristensen left review comments

@mvlipka mvlipka mvlipka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvazarkar @mvlipka @leechristensen