Live Metrics Block Long Load Time

[Jon-Corey]

Description

After updating from v15.1 to v16.6, we noticed that the Live Metrics block on Check-in Manager is now taking over 30 seconds to load on the initial load, even on high-end hardware with little load. On smaller hardware, I've observed this block taking taking over 90 seconds to load on the initial load.

After stepping through the code, this issue seems to be caused by this line of LiveMetrics.ascx.cs, which was added in this commit. This expensive operation is running multiple times per load since it is in a for loop, which compounds the issue.

Note, this only seems to affect larger Rock environments with lots of groups that people can check into.

Actual Behavior

On large Rock environments, the Live Metrics block takes a really long time to load.

Expected Behavior

The Live Metrics block should take a reasonable amount of time to load. The load time should be closer to about 3 seconds or less on large environments like it was previously.

Steps to Reproduce

1. Go to a Rock environment with a large number of check-in groups
2. Go to a page with the Live Metrics block on it
3. Observe that the page takes a long time to load

Issue Confirmation

• Perform a search on the Github Issues to see if your bug or enhancement is already reported.
• Reproduced the problem on a fresh install or on the demo site.

Rock Version

v16.6, v16.8

Client Culture Setting

en-US