Communication From Name and From Address fields do not resolve all lava available

[andypullen]

Description

The From Name and From Address fields on the Communication Wizard block don't resolve all lava available to the email, specifically the Person object. It is therefore not possible to send an email from {{ Person | Campus | Property:'Name' }} or {{ Person | Campus | Property:'LeaderPersonAlias' }}. The Subject field and message body can resolve the Person object.

Looks to be closely related to #2388, but because the fields both state that "{{ Lava }}" is available in the tooltip, all the lava objects that are available in the rest of the email should be available in the From Name and From Address fields as well.

Actual Behavior

Entering anything from the Person object does not render the expected in the From Name or From Address fields.

Expected Behavior

As stated above, all the lava objects that are available in the rest of the email should be available in the From Name and From Address fields as well.

Steps to Reproduce

• Start a new Communication using the wizard
• Set the From Name and Subject fields to {{ Person.NickName }}
• Send the email
• The subject will properly render the recipient's nick name, but the From name will be the organization's default, showing that it does not render.

We use SendGrid, if that matters.

Issue Confirmation

• Perform a search on the Github Issues to see if your bug or enhancement is already reported.
• Reproduced the problem on a fresh install or on the demo site.

Rock Version

16.7

Client Culture Setting

en-US

[chead4]

@andypullen Hi Andy - Thanks for bringing this issue to our attention! It seems an idea wasn't created when initially reported with #2388. We encourage you to submit an idea via https://community.rockrms.com/ideas-changes. This gives the entire community a chance to provide input and help us determine its priority.

In the meantime, I'll leave this issue open and we'll remove the help text for the 'From Name' and 'From Address' fields.

[JimMichael]

If this is just a visual bug and Lava isn't really supported in those fields at ALL, maybe this would be the ideal time to add it to the forthcoming email wizard since it's still under development?

[nlabarbera]

To clarify here, after some internal discussion and a deeper review, we won't not be removing the Lava help text. While it does support some Lava, as @andypullen pointed out, it doesn’t resolve all Lava cases.

This should be a straightforward fix, but it will require thorough testing to ensure stability. We’ll make sure to include this in a future 17.x release.

[andypullen]

Thanks @nlabarbera, I think that's the right choice. In the meantime, if it were possible to document what lava is available in those fields, that would be helpful. I know it's likely different if the communication starts with a Group, Report, or something else, so that might be a tall order...

[cjfountain]

We have a similar issue in v16.8. The Lava is rendering in the From Name and From Address, but not rendering in the Reply To Address.