Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing cache tags for categories and cms blocks #1

Open
diazwatson opened this issue Sep 20, 2017 · 2 comments
Open

Missing cache tags for categories and cms blocks #1

diazwatson opened this issue Sep 20, 2017 · 2 comments
Labels
bug

Comments

@diazwatson
Copy link
Contributor

diazwatson commented Sep 20, 2017 •
edited
Loading

The category menu options and cms blocks rendered by this module do not have cache tags.

As a result if we update a cms block or a category and we want to see those changes in the front we have to flush the full page cache or wait for it to expires.

References

  • \Magento\Theme\Block\Html\Topmenu::getCacheTags
  • \Magento\Cms\Model\Block::getIdentities
  • \Space48\CmsMenu\Block\Html\CmsTopmenu

Way to test it

On an environment with Varnish

  • Check response headers
  • Check Access.log and look for urls with esi on it
@diazwatson diazwatson self-assigned this Sep 20, 2017
@diazwatson diazwatson added the bug label Sep 20, 2017
@diazwatson diazwatson changed the title Missing Category and Block Cache Tags Missing cache tags for categories and cms blocks Sep 20, 2017
@diazwatson
Copy link
Contributor Author

I believe this was fixed in b5e73e7 could you guys confirm?
@DanK00 @jakeworrall

@dangron
Copy link
Contributor

dangron commented Mar 11, 2019

@diazwatson I believe so, try updating to latest tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@diazwatson @dangron