Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing use of ShouldSchedule flag #128

Open
jakthra opened this issue Oct 30, 2019 · 2 comments
Open

Confusing use of ShouldSchedule flag #128

jakthra opened this issue Oct 30, 2019 · 2 comments
Assignees

Comments

@jakthra
Copy link
Contributor

jakthra commented Oct 30, 2019

The downlink and uplink scheduler logic requires the .Mac.ShouldSchedule flag. This is confusing when calling the Monster.scheduleUL() function as this does nothing unless the ShouldSchedule flag is set.

I propose the function scheduleUL/scheduleDL is to be independent from the flag, and thus not called if the flag is set to 0.

@MonsterMarkus MonsterMarkus self-assigned this Nov 7, 2019
@MonsterMarkus
Copy link
Collaborator

As per the latest commit the check is now moved outside schedule functions in the EvolvedNodeB class and is moved to the monster.m simulation instead. The check is now done with a for loop.

@MonsterMarkus
Copy link
Collaborator

Changed the solution to include a warning, thus preventing calling the function without setting the proper flag outside the simulation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants