From 00ca2dee06b1eef40661af83c4cfcc4d94008c4b Mon Sep 17 00:00:00 2001
From: thomas <thomas.chiantia@gmail.com>
Date: Thu, 3 Nov 2022 14:34:22 -0400
Subject: [PATCH] Export SocketIter and remove SocketIter cloneing

This fixes the SocketIter type (again) by holding a reference to the
socket (instead of cloneing). Doing this removes unecessary calls to
`ref` and `unref` when cloning and droping the iterator.

Also - the SocketIter type is exported as MonitorSocketIter. This allows
creating custom Iter types which can be used to map off the event types.

Signed-off-by: thomas <thomas.chiantia@gmail.com>
---
 src/lib.rs     |  5 ++++-
 src/monitor.rs | 29 ++++++++++-------------------
 2 files changed, 14 insertions(+), 20 deletions(-)

diff --git a/src/lib.rs b/src/lib.rs
index 86de99a..3874e9b 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -18,7 +18,10 @@ pub use enumerator::{Devices, Enumerator};
 #[cfg(feature = "hwdb")]
 pub use hwdb::Hwdb;
 pub use list::{Entry, List};
-pub use monitor::{Builder as MonitorBuilder, Event, EventType, Socket as MonitorSocket};
+pub use monitor::{
+    Builder as MonitorBuilder, Event, EventType, Socket as MonitorSocket,
+    SocketIter as MonitorSocketIter,
+};
 pub use udev::Udev;
 
 macro_rules! try_alloc {
diff --git a/src/monitor.rs b/src/monitor.rs
index b3cd2a7..65eaf1f 100644
--- a/src/monitor.rs
+++ b/src/monitor.rs
@@ -139,7 +139,7 @@ pub struct Socket {
 impl Socket {
     /// Create an iterator of socket event messages
     pub fn iter(&self) -> SocketIter {
-        SocketIter::new(self)
+        SocketIter::new(&self)
     }
 }
 
@@ -161,37 +161,28 @@ impl AsRawFd for Socket {
     }
 }
 
-pub struct SocketIter {
-    udev: Udev,
-    monitor: *mut ffi::udev_monitor,
+/// Iterator of socket events
+pub struct SocketIter<'a> {
+    socket: &'a Socket,
 }
 
-impl SocketIter {
+impl<'a> SocketIter<'a> {
     /// Create a socket by cloning the underlying udev instance
-    fn new(socket: &Socket) -> SocketIter {
-        SocketIter {
-            udev: socket.inner.udev.clone(),
-            monitor: unsafe { ffi::udev_monitor_ref(socket.inner.monitor) },
-        }
-    }
-}
-
-impl Drop for SocketIter {
-    fn drop(&mut self) {
-        unsafe { ffi::udev_monitor_unref(self.monitor) };
+    fn new(socket: &'a Socket) -> SocketIter<'a> {
+        SocketIter { socket }
     }
 }
 
-impl Iterator for SocketIter {
+impl<'a> Iterator for SocketIter<'a> {
     type Item = Event;
 
     fn next(&mut self) -> Option<Event> {
-        let ptr = unsafe { ffi::udev_monitor_receive_device(self.monitor) };
+        let ptr = unsafe { ffi::udev_monitor_receive_device(self.socket.inner.monitor) };
 
         if ptr.is_null() {
             None
         } else {
-            let device = Device::from_raw(self.udev.clone(), ptr);
+            let device = Device::from_raw(self.socket.inner.udev.clone(), ptr);
             Some(Event { device })
         }
     }