1.20.4 Functionality #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to also mention that merging this will result breaking the auto-artifact-building system as the Spigot's NMS aren't available online anywhere and can only be built locally. I've also tried to remove all the NMS parts and change them into reflections, but because we're overriding methods from a class unobtainable during compilation that's sadly not possible without much complex reflection logic and dynamic class creation which would make it more unreadable and hard to read. //EDIT I tried making it with Javassist but without a chance... https://pastebin.com/WwPrMsjG |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
I've updated the plugin to work with 1.20.4 and ensured that custom glow enchantment remains working on the latest version.
Additions/Changes/Removals
Due to hard spigot Enchantment class changes, I've had to use NMS (net.minecraft.server) to make the glowing enchant work properly.
As of that, I had to separate the Core part of the plugin and the NMS part in the projetct so the dependencies wouldn't mix alltogether and possibly even prevent compilation.
Related Issues
Resolves #90
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values