Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Milk doesnt produce sound when interacting with tinkers fluid containers #5185

Open
Zen9890 opened this issue Mar 2, 2024 · 2 comments
Open

Milk doesnt produce sound when interacting with tinkers fluid containers #5185

Zen9890 opened this issue Mar 2, 2024 · 2 comments
Labels
1.18 Issue affects 1.18 Bug Issue describes unintended or broken behavior Confirmed Issue has been verified as being caused by Tinkers, or an enhancement is planned to be added Forge Issue is caused by Forge or a Forge issue describes this issue. Resolution is often delayed. Mantle Issue is actually a bug in Mantle, the library Tinkers' Construct depends on

Comments

@Zen9890
Copy link

Zen9890 commented Mar 2, 2024

Minecraft Version

1.18.2

Forge Version

40.2.17

Mantle Version

1.9.50

Tinkers' Construct Version

3.7.1.155

Describe your issue

Taking/inserting milk fluid into tinkers container doesnt produce any sound, this includes:
All seared/scorched tanks
Seared melter
Smeltery
Foundry
Alloyer
Tools that have fluid capacity

Crash Report

No response

Other mods

Tinkers construct, mantle

Tried reproducing with just Tinkers?

Yes

Performance Enchancers

None of the above

Searched for known issues?

Searched open issues
@Zen9890 Zen9890 added 1.18 Issue affects 1.18 Bug Issue describes unintended or broken behavior Unreviewed Issue is new and is awaiting the team to review it labels Mar 2, 2024
@ShinyPorygon ShinyPorygon added Confirmed Issue has been verified as being caused by Tinkers, or an enhancement is planned to be added and removed Unreviewed Issue is new and is awaiting the team to review it labels Mar 3, 2024
@KnightMiner KnightMiner added Mantle Issue is actually a bug in Mantle, the library Tinkers' Construct depends on Forge Issue is caused by Forge or a Forge issue describes this issue. Resolution is often delayed. labels Apr 1, 2024
@KnightMiner
Copy link
Member

This is really a forge bug. We could work around it, though Mantle is the place for the workaround.

The 1.19 forge API led me to implement the workaround by default as they actually marked fluid sounds as nullable.

@KnightMiner
Copy link
Member

This fix did not make it into 1.18.2, but it is really a Forge bug anyways. Will leave this issue open for now in case another bug fix build is needed for 1.18.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.18 Issue affects 1.18 Bug Issue describes unintended or broken behavior Confirmed Issue has been verified as being caused by Tinkers, or an enhancement is planned to be added Forge Issue is caused by Forge or a Forge issue describes this issue. Resolution is often delayed. Mantle Issue is actually a bug in Mantle, the library Tinkers' Construct depends on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KnightMiner @ShinyPorygon @Zen9890