Fix IsKeyDown and AreKeysDown Processed Event #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the input is ``processed``, then it'll void ``IsKeyDown`` and ``AreKeysDown``.
Fix IsKeyDown and AreKeysDown Processed Event
|
This has the potential to leak state. If a key is pressed down and isn't marked as processed, but then is marked as processed on the release state, then the state of the key will be stuck. I think the fix for this is to simply remove it from the State table in the InputEnded handler regardless of the processed state. |
Fix State Leak for InputEnded
Uses the newly enabled ``Once`` for Signals.
Add ConnectOnce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the input is
processed, then it'll voidIsKeyDownandAreKeysDown. Closes #87