Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework of the website #2561

Closed
6 tasks done
Olyno opened this issue Oct 13, 2019 · 10 comments
Closed
6 tasks done

Rework of the website #2561

Olyno opened this issue Oct 13, 2019 · 10 comments
Labels
documentation Related to Skript's official documentation. enhancement Feature request, an issue about something that could be improved, or a PR improving something.

Comments

@Olyno
Copy link
Contributor

Olyno commented Oct 13, 2019

The rework of the Skript's website will contain these issues:

Please post your suggestions or ideas about this rework here.

(This issue is a improvement and continuity of #2506)

@Wealthyturtle Wealthyturtle added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Oct 14, 2019
@bensku bensku added the documentation Related to Skript's official documentation. label Oct 15, 2019
@noftaly
Copy link
Contributor

noftaly commented Oct 20, 2019

idk if this is valid, but: SkriptLang/skript-docs#14

@Olyno
Copy link
Contributor Author

Olyno commented Oct 20, 2019

idk if this is valid, but: SkriptLang/skript-docs#14

I don't really know if it's possible so I will add it if we can do it

@Olyno
Copy link
Contributor Author

Olyno commented Dec 6, 2019

Website available here: https://olyno.github.io/skript-website/

@bensku
Copy link
Member

bensku commented Dec 7, 2019

Looks great! Aside that, there are a few issues you could look at:

  1. PageSpeed Insights reports a rather low score on mobile, and can't reach 100 even on desktop. Since better mobile support was one of goals of this change, I feel this is quite important. Current website scores 100 on both mobile and desktop, and is currently usable (but ugly) on mobile (except Safari).
  2. Core functionality does not work without Javascript. Core functionality does not include search or other dynamic content.
  3. External links to documentation pages do not work (tested on Firefox 70, Linux). This is probably most critical of the issues, and I suspect it is related to issue 2.

@Olyno
Copy link
Contributor Author

Olyno commented Dec 7, 2019

PageSpeed Insights reports a rather low score on mobile, and can't reach 100 even on desktop.

Page speed has been fixed:

  • Mobile: 92
  • Desktop; 100

I think not I can make a better performance than that because the new website requires images that the old doesn't.

Core functionality does not work without Javascript.

Agree, but it's what I call a modern website. The main issue you have when you don't use these tools (as ReactJs, VueJs or here SvelteJs) is that you must copy paste the same thing everytime you need it. The strength of theses technologies is what we call reusable components. You create a component and can reuse it everywhere you need it. Each components can have values insides when render, and takes only 1 line to add. When you edit 1 component, it edits everywhere you use it (so a big gain of time).
That's the reason why I will not remove Javascript here because it will be stupid. You require a lot of time Javascript (as documentation pages) in this website.

External links to documentation pages do not work

Hmmm I will have a look in. It's probably javascript as you said. I will add a polyfill to make it compatible everywhere.

@bluelhf
Copy link
Contributor

bluelhf commented Dec 8, 2019

@Olyno Maybe use the latest github release and parse the redirect url to get the version to show in the "Download latest" button instead of manually setting it?

(Use https://github.com/SkriptLang/Skript/releases/latest/, wait for it to redirect, then split the url by / and get the last element)

Oh, and replace Bukkit platform with Spigot and Paper platforms in the description of Skript on the main page

@Olyno
Copy link
Contributor Author

Olyno commented Dec 8, 2019

@Olyno Maybe use the latest github release and parse the redirect url to get the version to show in the "Download latest" button instead of manually setting it?

(Use https://github.com/SkriptLang/Skript/releases/latest/, wait for it to redirect, then split the url by / and get the last element)

Oh, and replace Bukkit platform with Spigot and Paper platforms in the description of Skript on the main page

I will have a look in, thanks for your suggestion!

@bensku
Copy link
Member

bensku commented Dec 8, 2019

@Olyno My suggestion would have been to use server side rendering. It seems you did exactly that, because the site now works without Javascript. It also loads much faster and external links to it appear to be working.

All in all, I think the website is ready. We can start figuring out how we'll be replacing the current site with it. Thanks for great work!

@APickledWalrus
Copy link
Member

A few things I noticed:

  • The main description should be updated, especially now that the website includes tutorials (description says it does not).
  • The text on the color picker is not completely within the white box (it is a little below) and some text is moved it seems (see below)
  • The color picker seems to be cut off by the scrollbar.

image

@Olyno
Copy link
Contributor Author

Olyno commented Jan 2, 2020

The text on the color picker is not completely within the white box (it is a little below) and some text is moved it seems (see below)

Unlucky for me, the color picker is a component that I didn't create, so I can't edit it

The other things will be fix soon!

@Olyno Olyno mentioned this issue Mar 12, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to Skript's official documentation. enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

No branches or pull requests

7 participants