-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Long-term plans on Skript #121
Comments
I'll take on Vector support if I have time. |
For the math library this link should be interesting: http://javaluator.sourceforge.net/en/home It does all the parsing for you! |
@Namnodorel What would the syntax be in Skript? |
@xXAndrew28Xx I'd go with 'calculate [math expression]'. Skript would need to replace variable names if existent (like player health) and then hand the expression over to the library |
I would not like to take extra dependencies for Skript. The idea is to fix bugs in current math expression, and maybe add some features. About vectors, implementing them well is not going to be trivial task. It will not be one of the "big tasks", since it won't take months to do... Tt will, howewer, need good knowledge of both Bukkit vectors and Skriptäs internals. |
It's 26KB. |
Why do you want to avoid dependencies? During my projects I've learned an important rule while programming: Don't reinvent the wheel. It makes no sense to write a custom solution when someone has done the work already and has shared their work (which is also most likely of a higher quality and has more features/less bugs than a custom solution that was just a minor task in the project). |
Well, few reasons.
So... External libraries can be used for Skript, but I will not take the responsibility. If someone can guarantee support for that in future and also make it work well enough; go ahead. It just might be easier to tweak existing code. |
Maybe you can remove some lines. But this is only advice. |
I made bunch of expressions for vectors (20ish). Thought you might want to add them :) |
@bensku Should it be like Bukkit events that you create and call it? Like how MundoSK did it
Not much necessary I think, since it is a thing every addon does (at least the public one), but how would we check which addon used an api method? |
Also doesn't the JavaDocs specify Skript#registerAddon is not required for the addon to work? |
Hmm, I've been thinking of "exporting" Skripts to jars for a while but I can't think of a good way to do it. Optimally I wouldn't want to require the addon classes, but I might have to somehow include those in the outputted jar itself for it to work. |
Can you explain what you envisioned with
then:
|
That's the case already |
Custom event support would involve rewriting some parts of event value handling, indeed. |
Also, the order of operations actually functions very well, Skript just uses pattern order to express operator priority. |
|
Any update to a Sponge version? |
Perhaps - if someone gets around to making a fork of Skript that is Sponge API compatible. The problem is that Skript relies very heavily on Spigot/Paper's API, so reconfiguring Skript for Sponge will not be an easy task. @icemails |
While Sponge team has good reasons for 1.14 support taking a long time, primary goal of Skript is currently to support Minecraft 1.13 and newer versions. I have zero interest in working on anything new based on Minecraft 1.12. As @Wealthyturtle mentioned, there are significant practical problems too. |
Removed two of the taks from the list, the one about reflection in Skript (skript-mirror exists now, a built-in solution doesn't really seem worth implementing) and the other about hooks on other plugins (we decided to leave hooks to addons, and I personally want to move the current hooks of Skript to their own, specialized addons). |
Will 1.9 - 1.11 support actually still be useful in the future ? |
I personally don't mind supporting them as long as their maintenance doesn't become a burden and as of now it's not more than some checks. |
Personally, I'd love to drop support for 1.9.x -> 1.11.1 In all fairness I'd love to see all 1.12.2 and below dropped. Skript is getting kinda messy trying to support 2 very different APIs for blocks and items. I know we won't be dropping 1.12.2 any time soon, but maybe we should consider dropping 1.9.x - 1.11.x to give people the understanding that Skript is moving forward and staying current. |
Moving foward and staying current have nothing to do with version support, with all the effort that has been put into aliases to support 1.11-1.9 and the fact that this doesn't cause any huge maintenance burden so far, I don't believe we should drop it just because we can. If it becomes a huge issue for us when implementing a feature, it may as well be considered. |
|
Another one could be an lsp or language support for the script language and have an official vscode extensions that adds that support and some nice features along with it. |
There are some issues with Skript that I do not really have time to look at. If you want to take some of these tasks, reply here.
Big tasks:
The text was updated successfully, but these errors were encountered: