fix(mangademon): rewrite most of the source to account for a site remake #756

AlokSwaminathan · 2024-09-04T22:33:39Z

Checklist:

Updated source's version for individual source changes
Updated all sources' versions for template changes
Set appropriate nsfw value
Did not change id even if a source's name or language were changed
Tested the modifications by running it on the simulator or a test device

Closes #753

If searching then other params just don't work, no reason to check for them and append them to the url

src/rust/en.mangademon/src/parser.rs

Co-authored-by: Skitty <[email protected]>

src/rust/en.mangademon/src/parser.rs

Co-authored-by: Skitty <[email protected]>

Skittyblock

seeing a crash when opening martial peak due to duplicate chapter identifiers. double check how you're assigning chapter ids and make sure they're unique, and make sure to test on device

AlokSwaminathan · 2024-09-29T17:18:07Z

seeing a crash when opening martial peak due to duplicate chapter identifiers. double check how you're assigning chapter ids and make sure they're unique, and make sure to test on device

I've been reading from mangademon with this version of the source for a few weeks, I have 60 from it and I haven't noticed any issues. What chapter on martial peak are you having problems with, I tested a few chapters on there and they seem to work for me.

Skittyblock · 2024-09-29T17:57:26Z

interestingly enough, it's only happening when run on the simulator. none of the images load for me on device though. the culprit for martial peak is /chaptered.php?manga=1&chapter=3705, which I can see on the site is listed twice. this is their mistake, but you should probably filter out duplicates on our end within the source

AlokSwaminathan added 18 commits September 3, 2024 13:37

fix: update BASE_URL

a633fe5

fix: update manga list path

8dc5128

fix: add break to stop unecessary matching

4edc27e

If searching then other params just don't work, no reason to check for them and append them to the url

fix: parse_manga_list

be156ff

chore: formatting

295ca5c

fix: get_manga_id

48d5f06

fix: get_manga_url

6a3b233

feat: add parsing for latest manga listings

a822f26

chore!: format parse_latest_manga_list

3acbaf1

fix: get_manga_details

d6edf3a

fix: get_chapter_list parse_chapter_list

5061378

fix: add url to manga details

3bdf896

chore: remove unused function

521976c

fix: make chapter use chapter id not manga id

125ac4e

fix: get_page_list parse_page_list

2f5d2bc

feat: make chapter id include numbered manga id

e96a96d

chore: update source version and URL

b17374d

chore: format files

4ce2e92

Skittyblock requested changes Sep 16, 2024

View reviewed changes

src/rust/en.mangademon/src/parser.rs Outdated Show resolved Hide resolved

Update src/rust/en.mangademon/src/parser.rs

0aa0aa7

Co-authored-by: Skitty <[email protected]>

Skittyblock reviewed Sep 28, 2024

View reviewed changes

src/rust/en.mangademon/src/parser.rs Outdated Show resolved Hide resolved

Update src/rust/en.mangademon/src/parser.rs

3e11f62

Co-authored-by: Skitty <[email protected]>

Skittyblock requested changes Sep 29, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(mangademon): rewrite most of the source to account for a site remake #756

fix(mangademon): rewrite most of the source to account for a site remake #756

AlokSwaminathan commented Sep 4, 2024 •

edited

Loading

Skittyblock left a comment

AlokSwaminathan commented Sep 29, 2024

Skittyblock commented Sep 29, 2024

fix(mangademon): rewrite most of the source to account for a site remake #756

Are you sure you want to change the base?

fix(mangademon): rewrite most of the source to account for a site remake #756

Conversation

AlokSwaminathan commented Sep 4, 2024 • edited Loading

Skittyblock left a comment

Choose a reason for hiding this comment

AlokSwaminathan commented Sep 29, 2024

Skittyblock commented Sep 29, 2024

AlokSwaminathan commented Sep 4, 2024 •

edited

Loading