Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove private GitHub package registry usage #123

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Conversation

rcj-siteimprove
Copy link
Contributor

No description provided.

@rcj-siteimprove rcj-siteimprove requested a review from a team as a code owner January 17, 2025 07:55
Copy link

changeset-bot bot commented Jan 17, 2025

⚠️ No Changeset found

Latest commit: 3b37bde

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rcj-siteimprove rcj-siteimprove requested a review from Jym77 January 17, 2025 07:55
@rcj-siteimprove rcj-siteimprove self-assigned this Jan 17, 2025
@rcj-siteimprove rcj-siteimprove added npm Related to npm dependencies dependencies Related to dependencies internal Change that only affects internal APIs or other non-public aspects labels Jan 17, 2025
Copy link
Contributor

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to regenerate yarn.lock to point at the new registry. Simply delete it and yarn install again should do the trick.

Jym77
Jym77 previously approved these changes Jan 17, 2025
@rcj-siteimprove
Copy link
Contributor Author

The build broke, not exactly sure why. The first error is

node_modules/@types/enzyme/node_modules/@types/react/index.d.ts:3155:14 - error TS2300: Duplicate identifier 'LibraryManagedAttributes'.

@Jym77
Copy link
Contributor

Jym77 commented Jan 17, 2025

🙈 There seems to be unrelated updates in the lockfile (due to semver ranges in dependencies) that end up exploding like that.

I guess we can keep the old lockfile, and the actual change will happen with the next Alfa release 🤔

@Jym77
Copy link
Contributor

Jym77 commented Jan 17, 2025

jym@dk-jym02:/mnt/c/Projects/a11y/alfa-integrations (use-public-npm-registry *%=)$ yarn why -R @types/react
├─ @siteimprove/alfa-enzyme@workspace:packages/alfa-enzyme
│  ├─ @types/enzyme@npm:3.10.18 (via npm:^3.10.8)
│  │  └─ @types/react@npm:16.14.62 (via npm:^16)
│  └─ @siteimprove/alfa-react@workspace:packages/alfa-react [a1604] (via workspace:^ [a1604])
│
└─ @siteimprove/alfa-react@workspace:packages/alfa-react
   ├─ @types/react-test-renderer@npm:18.3.1 (via npm:^18.3.0)
   │  └─ @types/react@npm:18.3.18 (via npm:^18)
   └─ @types/react@npm:18.3.18 (via npm:^18.3.3)

jym@dk-jym02:/mnt/c/Projects/a11y/alfa-integrations (use-public-npm-registry %>)$ git switch main
jym@dk-jym02:/mnt/c/Projects/a11y/alfa-integrations (main %=)$ yarn install
(…)

jym@dk-jym02:/mnt/c/Projects/a11y/alfa-integrations (main %=)$ yarn why -R @types/react
├─ @siteimprove/alfa-enzyme@workspace:packages/alfa-enzyme
│  ├─ @types/enzyme@npm:3.10.12 (via npm:^3.10.8)
│  │  └─ @types/react@npm:18.3.3 (via npm:*)
│  └─ @siteimprove/alfa-react@workspace:packages/alfa-react [a1604] (via workspace:^ [a1604])
│
└─ @siteimprove/alfa-react@workspace:packages/alfa-react
   ├─ @types/react-test-renderer@npm:18.3.0 (via npm:^18.3.0)
   │  └─ @types/react@npm:18.3.3 (via npm:*)
   └─ @types/react@npm:18.3.3 (via npm:^18.3.3)

So, @types/enzyme used to depend on @types/react: * (resolved as 18) but now depends on @types/react: 16 which causes 2 @types/react to exist and collide…

@Jym77 Jym77 merged commit 5c6e2f8 into main Jan 20, 2025
4 checks passed
@Jym77 Jym77 deleted the use-public-npm-registry branch January 20, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to dependencies internal Change that only affects internal APIs or other non-public aspects npm Related to npm dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants