Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide default worker name and avoid duplicates #8

Open
pulkitsinghal opened this issue Sep 5, 2016 · 0 comments
Open

Provide default worker name and avoid duplicates #8

pulkitsinghal opened this issue Sep 5, 2016 · 0 comments
Assignees

Comments

@pulkitsinghal
Copy link
Contributor

pulkitsinghal commented Sep 5, 2016

Suggestion:

  1. Running a command to create a worker results in an empty worker_name. By default, we should translate the "docker_image": "org/image" to be one of the following:
    1. "worker_name": "org/image" or
    2. "worker_name": "org_image" or
    3. "worker_name": "org-image" or
    4. "worker_name": "image"
  2. When creating a worker with the same image repeatedly. We should decide if we want to avoid duplicates and enforce uniqueness based on docker_image or worker_name. Whatever we decide, we should enforce it.
    1. I vote for worker_name based uniqueness.
      1. I have tested that if I pass in the same worker name right now (not talking about empty or defaults anymore), it creates a new id for me every time in the DB, and we can improve upon that as it doesn't seem desirable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants