Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how to properly handle in-app engine's tests #221

Open
3 tasks
st0012 opened this issue Jan 4, 2024 · 1 comment
Open
3 tasks

Investigate how to properly handle in-app engine's tests #221

st0012 opened this issue Jan 4, 2024 · 1 comment
Labels
help-wanted Extra attention is needed

Comments

@st0012
Copy link
Member

st0012 commented Jan 4, 2024

Assume an user has a Rails app called my_app, which has in-app engines with the following file structure:

my_app
├── app
├── config
├── (other Rails app folders)
└── engines
    └── my_engine
        └── test/my_test.rb

Todos

  • Check what's the official/best practice of running an in-app engine's unit tests

  • When opening my_test.rb from the my_app workspace, the code lens should generate such command:

    bundle exec bin/rails test engines/my_engine/test/my_test.rb
    

    We need to check if this are expected to work or not.

    • If the answer is no, it means tests are expected to be executed under the my_engine directory.
  • Is there any other common in-app Rails engine setup we should consider

@st0012 st0012 added the help-wanted Extra attention is needed label Jan 4, 2024
@vinistock
Copy link
Member

Can you explain why the current mechanism doesn't work?

We use the absolute path for running tests instead of relative exactly to try to avoid issues with nested projects, so I'm not sure what the problem is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants