Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation notice required after optional parameters #101

Open
D-Groenewegen opened this issue Mar 25, 2023 · 0 comments
Open

Fix deprecation notice required after optional parameters #101

D-Groenewegen opened this issue Mar 25, 2023 · 0 comments

Comments

@D-Groenewegen
Copy link

Issue

This (minor) issue is about https://github.com/SemanticMediaWiki/SemanticFormsSelect/blob/master/src/SemanticFormsSelectInput.php#L72

In PHP 8 adding required after optional parameters in a function/method has become deprecated (1). I don't know what's preferable as a solution: reshuffle the sequence or convert the required parameters to optional ones by adding defaults. I'll leave that up to your good judgment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant