bulktext API Correct Handlings of 1/0 Booleans
#2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had recently corrected a bug throughout the API which incorrectly handled boolean parameters being passed as 0s or 1s. They were handled as strings, and therefore constantly evaluating as
trueand causing unexpected behavior, we made an effort to make sure they were all properly being passed as ints. This PR fixes one instance that was missed in that initial sweep - based on user feedback.Code Changes
sefaria/views.py- Cast theuseTextFamilyparam results to an int.Notes
1, the response includes the primary category of the text.