Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Resolvables to be passed into Resolutions? #85

Open
perrygoy opened this issue Jun 6, 2023 · 2 comments
Open

Allow Resolvables to be passed into Resolutions? #85

perrygoy opened this issue Jun 6, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@perrygoy
Copy link
Member

perrygoy commented Jun 6, 2023

From a conversation on #83, when Resolutions inherited from BaseResolution (which inherited from pyhamcrest.BaseMatcher), we could pass Resolutions into Resolutions and pyhamcrest could do some neat magic. Now that we've done away with the BaseResolution, that magic is gone.

Is there a way we could detect whether a user has given us a Resolvable somewhere in their expected condition, and resolve that before passing it to pyhamcrest?
@perrygoy perrygoy added the enhancement New feature or request label Jun 6, 2023
@perrygoy perrygoy mentioned this issue Jun 6, 2023
Closed
@bandophahita
Copy link
Contributor

I have to compliment @jardilac91; I would not have thought to use the resolutions that way. It's rather clever.

@perrygoy
Copy link
Member Author

perrygoy commented Jun 6, 2023

Likewise! Very clever usage, i hope we can bring it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bandophahita @perrygoy