Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: prismlauncher-git wrong major and monir version due to it being hardcoded in the script #1960

Open
3 tasks done
sokripon opened this issue Sep 30, 2024 · 1 comment · May be fixed by #1961
Open
3 tasks done

[Bug]: prismlauncher-git wrong major and monir version due to it being hardcoded in the script #1960

sokripon opened this issue Sep 30, 2024 · 1 comment · May be fixed by #1961
Labels
bug

Comments

@sokripon
Copy link

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues/PRs to ensure it has not already been reported or fixed.
  • I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name

prismlauncher-git

Expected/Current Behaviour

The current manifest for prismlauncher-git has uses hardcoded 7.0 as the version number + the commit hash.
This results in the version being wrong for versions that are not 7.0

Steps to Reproduce

❯ scoop update prismlauncher-git
prismlauncher-git: 7.0-a634512 (latest version)
Latest versions for all apps are installed! For more information try 'scoop status'

Possible Solution

Creating a more complex checkver check.

Scoop and Buckets Version

❯ scoop --version
Current Scoop version:
859d1db5 (HEAD -> master, tag: v0.5.2, origin/master, origin/HEAD) chore(release): Bump to version 0.5.2 (#6080)

'main' bucket:
fbd80966c (HEAD -> master, origin/master, origin/HEAD) slang: Update to version 2024.13

'extras' bucket:
e4f03398a (HEAD -> master, origin/master, origin/HEAD) skype: Update to version 8.129.0.202

'versions' bucket:
25f6ec97b (HEAD -> master, origin/master, origin/HEAD) zettlr-nightly: Update to version 3.2.1-20240930

Scoop Config

❯ scoop config

last_update         virustotal_api_key                                               scoop_repo                              scoop_branch
-----------         ------------------                                               ----------                              ------------
30/09/2024 15:43:00 xxxxxxxxxxxxxxxxxx https://github.com/ScoopInstaller/Scoop master

PowerShell Version

❯ $PSVersionTable 
                                                                                                                                                                                                                         
Name                           Value                                                                                                                                                                                     
----                           -----                                                                                                                                                                                     
PSVersion                      7.4.2                                                                                                                                                                                     
PSEdition                      Core                                                                                                                                                                                      
GitCommitId                    7.4.2                                                                                                                                                                                     
OS                             Microsoft Windows 10.0.22635                                                                                                                                                              
Platform                       Win32NT                                                                                                                                                                                   
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}                                                                                                                                                                     
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Additional Softwares

No response
@sokripon sokripon added the bug label Sep 30, 2024
@sokripon
Copy link
Author

Working on it

@sokripon sokripon linked a pull request Sep 30, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[email protected]: Improve checkver check sokripon/Versions
1 participant
@sokripon