Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] homepage should not be downloaded when checkver script is specified #5704

Open
kazzarin opened this issue Oct 28, 2023 · 0 comments · May be fixed by #6090
Open

[Bug] homepage should not be downloaded when checkver script is specified #5704

kazzarin opened this issue Oct 28, 2023 · 0 comments · May be fixed by #6090
Labels

Comments

@kazzarin
Copy link

Bug Report

Current Behavior

When checkver.script is specified in a manifest and checkver.url is not, checkver defaults to requesting the homepage url before running the script. If that request errors, the script is never run and checkver fails.

Expected Behavior

When checkver.script is specified, homepage and checkver.url should be ignored and the script should run as expected.

Additional context/output

I changed the homepage for a manifest in my own bucket, which produced the following error:

> .\bin\checkver.ps1 oracle-graalvm
oracle-graalvm: The operation has timed out.
URL https://www.oracle.com/java/graalvm/ is not valid

Reverting the change fixed it. The same behaviour was observed in my bucket's excavator, so I'm sure it's not a problem with my local machine. The wiki docs on the script property don't mention if it can be used with checkver.url or homepage, so I assume based on the manifests in the given examples that checkver.script is intended to be used exclusively when specified.

Unrelated, the site seems to timeout because of the link in scoop's user agent.

Possible Solution

System details

Windows version: 11

OS architecture: 64bit

PowerShell version: 7.3.9

Additional software: Git

Scoop Configuration

{
    "aria2-enabled":  false,
    "aria2-warning-enabled":  false,
    "cat_style":  "plain",
    "debug":  true,
    "gh_token":  "redacted",
    "last_update":  "2023-10-27T22:05:56.4511315-04:00",
    "scoop_branch":  "develop",
    "scoop_repo":  "https://github.com/ScoopInstaller/Scoop",
    "show_update_log":  false,
    "use_external_7zip":  true
}
@kazzarin kazzarin added the bug label Oct 28, 2023
notPlancha added a commit to notPlancha/Scoop that referenced this issue Aug 5, 2024
@notPlancha notPlancha linked a pull request Aug 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant