Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to hide DMs from Home when Direct Chats pseudo space is enabled #47

Open
BurnyBoi opened this issue Jan 2, 2025 · 2 comments
Open
Labels
enhancement New feature or request feature:spaces

Comments

@BurnyBoi
Copy link

BurnyBoi commented Jan 2, 2025

Is your feature request related to a problem? Please describe.
I don't like that Home on the spaces bar includes DMs because it makes the list too long to scroll. I have the Direct Chats and Groups pseudo spaces enabled and prefer using those instead, but having all 3 buttons showing takes up more room on the bar.

Describe the solution you'd like
Add the option to hide DMs from Home when the Direct Chats pseudo space is enabled. This would then make Home function the same as Groups and then I could just hide Groups from the bar.

Describe alternatives you've considered
Being able to hide the Home button when Groups and Direct Chats are enabled could be an option, but could cause more confusion. For now I either just use the Groups pseudo space or deal with Home being a long list.

@SpiritCroc
Copy link
Member

Allowing to hide home makes more sense to me, rather then having two different meanings for two different things, which just causes unnecessary complexity.

The way the code works right now it's not straightforward to remove home (or replace it with something else) - it's always necessary to have a sane fallback when there are no spaces (which also happens when you do have spaces, but they just haven't loaded yet). So while I looked into this before it's not a big priority for me.

@SpiritCroc SpiritCroc added enhancement New feature or request feature:spaces labels Jan 3, 2025
@BurnyBoi
Copy link
Author

BurnyBoi commented Jan 5, 2025

The main issue that can arise when allowing to hide Home is that unless coded for it's possible to cause rooms to be inaccessible from the UI. Example: You select a space or pseudo space that limits the room list, then hide the Home button after. You might now be locked out of getting back to rooms not belonging to a space. This is why I suggested requiring DMs and Groups pseudo spaces to be enabled before you disable Home since then you still have the full list.

Being able to completely hide orphaned rooms from the UI could be considered a feature rather than a bug though so maybe it's better to allow that as a possibility?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature:spaces
Projects
None yet
Development

No branches or pull requests

2 participants