Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit the requirements and suggest improvements the actor path grouping mechanism #636

Open
lgajowy opened this issue Mar 9, 2023 · 2 comments
Assignees

Comments

@lgajowy
Copy link
Contributor

lgajowy commented Mar 9, 2023

see: https://github.com/ScalaConsultants/mesmer/pull/635/files#r1129459979

This task is to plan the work for fixing the actor path selection mechanism. The outcome should be GitHub issues that will be done in later versions (0.10.0 and further). If the fixes are easy, we can consider doing them right away, but we have to be cautious here (no need to prolong something that could be split)

@lgajowy lgajowy added this to the 0.9.0 milestone Mar 9, 2023
@ptrdom ptrdom assigned ptrdom and unassigned ptrdom Mar 15, 2023
@lgajowy lgajowy self-assigned this Mar 15, 2023
@lgajowy
Copy link
Contributor Author

lgajowy commented Mar 31, 2023

There's also an alternative direction to explore here: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/metricstransformprocessor#aggregate-label-values

We could aggregate the path label in the collector. Ofc that would require always using the collector but maybe that's ok. Note, that actor path is not the only "high cardinality attribute" that will need to be aggregated so it might make sense to use a ready-to-use generic transformer rather to have case-specific implementations for that.

@lgajowy
Copy link
Contributor Author

lgajowy commented Mar 31, 2023

Postponing that issue until we get actual user feedback on the actor path grouping mechanism.

@lgajowy lgajowy removed this from the 0.9.0 milestone Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants