Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Success result wording #53

Open
jeremiahsmall opened this issue Nov 30, 2015 · 0 comments
Open

Success result wording #53

jeremiahsmall opened this issue Nov 30, 2015 · 0 comments

Comments

@jeremiahsmall
Copy link

If you use directory instead of file paths, the success message is worded oddly.

>> 3 files lint free.

See https://github.com/SaschaGalley/grunt-phpcs/blob/master/tasks/phpcs.js#L69

The simplest fix would be to change the word file to path so instead the above message would read

>> 3 paths lint free.

While we're talking about the wording, there's also grunt-phplint, so I'm not sure talking about "lint free" in the result message of grunt-phpcs is the best choice. In the vernacular of PHPCS, they are called "sniff violations." If we use "sniff" it could be reworded like this

>> 3 paths contain no sniff violations.

If either or both of these wordings are supported, I'm happy to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant