Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #879 #883

Merged
merged 7 commits into from
Mar 30, 2023
Merged

Fix #879 #883

merged 7 commits into from
Mar 30, 2023

Conversation

jfhenon
Copy link
Collaborator

@jfhenon jfhenon commented Feb 6, 2023

fix #879

@github-actions
Copy link

github-actions bot commented Feb 6, 2023 •
edited
Loading

Coverage Report

Commit: c5c8754
Base: master@8619a17

Type Base This PR
Total Statements Coverage  59.58%  59.58% (+0%)
Total Branches Coverage  43.5%  43.5% (+0%)
Total Functions Coverage  52.48%  52.48% (+0%)
Total Lines Coverage  60.72%  60.72% (+0%)
Details (changed files)
FileStatementsBranchesFunctionsLines
Details (all files)
FileStatementsBranchesFunctionsLines
packages/svgcanvas/common/browser.js 83.33% 100% 33.33% 96%
packages/svgcanvas/common/util.js 10.87% 10.2% 42.86% 8.89%
src/editor/ConfigObj.js 45.1% 31.25% 78.57% 45.54%
src/editor/Editor.js 48.44% 36.62% 33.33% 49.02%
src/editor/EditorStartup.js 62.75% 33.61% 52.94% 62.43%
src/editor/MainMenu.js 39.64% 14.58% 50% 39.64%
src/editor/Rulers.js 79.03% 74.42% 83.33% 78.15%
src/editor/browser-not-supported.js 75% 75% 100% 75%
src/editor/contextmenu.js 39.13% 0% 12.5% 40.91%
src/editor/locale.js 64.29% 30% 100% 64.29%
src/editor/components/PaintBox.js 79.1% 63.64% 100% 79.69%
src/editor/components/index.js 100% 100% 100% 100%
src/editor/components/seButton.js 70% 69.7% 46.67% 70.18%
src/editor/components/seColorPicker.js 80.39% 72.73% 68.75% 82%
src/editor/components/seExplorerButton.js 73.47% 56.67% 58.82% 75.79%
src/editor/components/seFlyingButton.js 64% 41.38% 64.29% 63.51%
src/editor/components/seInput.js 65.96% 50% 50% 67.39%
src/editor/components/seList.js 68.54% 54.55% 47.62% 67.82%
src/editor/components/seListItem.js 67.5% 80% 33.33% 66.67%
src/editor/components/seMenu.js 74.07% 60% 42.86% 76.92%
src/editor/components/seMenuItem.js 67.5% 42.11% 55.56% 70.27%
src/editor/components/sePalette.js 96.97% 76.92% 100% 96.97%
src/editor/components/sePlainBorderButton.js 100% 100% 100% 100%
src/editor/components/sePlainMenuButton.js 100% 100% 100% 100%
src/editor/components/seSelect.js 79.66% 87.5% 52.94% 80.36%
src/editor/components/seSpinInput.js 83.33% 76.47% 55.56% 84.62%
src/editor/components/seText.js 62.07% 62.5% 40% 64.29%
src/editor/components/seZoom.js 92.52% 63.89% 92.86% 93.14%
src/editor/components/jgraduate/ColorValuePicker.js 25.3% 21.66% 33.33% 23.38%
src/editor/components/jgraduate/Slider.js 54.55% 52.15% 52.94% 58.33%
src/editor/components/jgraduate/jQuery.jGraduate.js 46.84% 35.97% 31.82% 47.41%
src/editor/components/jgraduate/jQuery.jPicker.js 51.3% 42.08% 65% 53.45%
src/editor/dialogs/SePlainAlertDialog.js 14.29% 0% 0% 14.29%
src/editor/dialogs/cmenuDialog.js 90.08% 86.96% 57.14% 94.17%
src/editor/dialogs/cmenuLayersDialog.js 74.24% 72.22% 37.5% 80.33%
src/editor/dialogs/editorPreferencesDialog.js 79.25% 76.09% 30% 79.62%
src/editor/dialogs/exportDialog.js 67.24% 50% 35.71% 70.91%
src/editor/dialogs/imagePropertiesDialog.js 55.56% 43.4% 25% 55.9%
src/editor/dialogs/index.js 100% 100% 100% 100%
src/editor/dialogs/seAlertDialog.js 33.33% 100% 0% 33.33%
src/editor/dialogs/seConfirmDialog.js 25% 0% 0% 25%
src/editor/dialogs/sePromptDialog.js 20.83% 0% 28.57% 20.83%
src/editor/dialogs/seSelectDialog.js 25% 100% 0% 25%
src/editor/dialogs/svgSourceDialog.js 76% 82.35% 35.29% 75.68%
src/editor/dialogs/se-elix/define/NumberSpinBox.js 100% 100% 100% 100%
src/editor/dialogs/se-elix/src/base/NumberSpinBox.js 96.3% 88.68% 84.62% 96.3%
src/editor/dialogs/se-elix/src/plain/PlainNumberSpinBox.js 100% 100% 100% 100%
src/editor/extensions/ext-eyedropper/ext-eyedropper.js 54.93% 38.46% 62.5% 65%
src/editor/extensions/ext-eyedropper/locale/en.js 100% 100% 100% 100%
src/editor/extensions/ext-grid/ext-grid.js 47.78% 40% 50% 48.86%
src/editor/extensions/ext-grid/locale/en.js 100% 100% 100% 100%
src/editor/extensions/ext-markers/ext-markers.js 29.27% 27.5% 57.14% 30.87%
src/editor/extensions/ext-opensave/ext-opensave.js 25.53% 0% 23.08% 26.47%
src/editor/extensions/ext-opensave/locale/en.js 100% 100% 100% 100%
src/editor/extensions/ext-panning/ext-panning.js 73.33% 33.33% 85.71% 73.33%
src/editor/extensions/ext-panning/locale/en.js 100% 100% 100% 100%
src/editor/extensions/ext-polystar/ext-polystar.js 94.14% 62.9% 88.89% 93.93%
src/editor/extensions/ext-polystar/locale/en.js 100% 100% 100% 100%
src/editor/extensions/ext-shapes/ext-shapes.js 97.5% 65.38% 100% 97.37%
src/editor/extensions/ext-shapes/locale/en.js 100% 100% 100% 100%
src/editor/extensions/ext-storage/ext-storage.js 64.84% 39.71% 58.33% 64.84%
src/editor/extensions/ext-storage/storageDialog.js 91.94% 86.67% 70% 93.33%
src/editor/locale/lang.en.js 100% 100% 100% 100%
src/editor/panels/BottomPanel.js 79.22% 53.33% 63.64% 81.69%
src/editor/panels/LayersPanel.js 43.56% 13.04% 22.22% 44.59%
src/editor/panels/LeftPanel.js 79.66% 37.5% 75% 81.03%
src/editor/panels/TopPanel.js 74.7% 61.84% 67.12% 76.47%

@jfhenon
Copy link
Collaborator Author

jfhenon commented Mar 30, 2023

This is a partial fix. There are remaining (and potentially more complex) issues to fix

@jfhenon jfhenon merged commit 13cdaed into master Mar 30, 2023
@jfhenon jfhenon deleted the fix-#879 branch March 30, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

W3C example breaks on layer move
1 participant
@jfhenon