Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midterm Review - Timeline #113

Open
Rafaelflores92 opened this issue Apr 11, 2014 · 8 comments
Open

Midterm Review - Timeline #113

Rafaelflores92 opened this issue Apr 11, 2014 · 8 comments
Assignees
Milestone

Comments

@Rafaelflores92
Copy link
Contributor

  • I know you guys did a lot of work on this. But it’s pretty janky. It’s wider than the page, so it causes weird horizontal scrolling.
  • It’s hard to tell that you can scroll vertically to the content within the timeline.
  • It’s a crapshoot on what you actually end up scrolling on the page when you are scrolling around. Sometimes you mean to scroll down and it goes to the next area instead.
  • That lego pirate image is totally inappropriate.
  • Where is stage 8?
  • The actual dates at the bottom are really awkward, and confusing. They say 2006 – 2014. It’s just weird…
  • On desktop the image is huge and the text gets really small, if you cant fix that using the timeline plugin, just remove the image entirely.
  • Getting some 404 errors /timeline_source/css/timeline.png and loading.png
@everett-f
Copy link

So I got rid of the dates aspect of the time line and it looks pretty good. I'm just gonna work on adjusting the picture and text combination

@everett-f
Copy link

I fixed the missing 404 errors, timeline looks a little better now.

@everett-f
Copy link

I may take out the function that determines if it is using mobile or tablet. When I made the function always return "desktop". It was a lot less "Janky" and easier to maneuver. I just have to adjust the side bars.

@everett-f
Copy link

@esteinborn I've fixed the majority of issues that you addressed in the email. I'm experimenting with disabling the timeline "swipe to navigate" feature. Right now it doesn't look great but it is a lot easier to maneuver through. Please check out the timeline on your computer and smartphone.

http://suny-albany-cci-inf362.github.io/whatev3r/guide/generaltimeline.html

Any input would be great, Thanks!

@esteinborn
Copy link
Member

The buttons aren't immediately visible on mobile unless you click them and at that point, its jarring to move when you didn't think you were going to. I'd remove the buttons on mobile, keep the touch slide feature

Remove the margin around the timeline, it flows off my iphone screen:
photo 2
photo 1

I'd also drop the bottom part with the stage timeline list entirely on mobile.

@everett-f
Copy link

@esteinborn If i switch back to the touch, I would have to figure out a way to prevent timelime plugin from misinterpreting a vertical swipe from a horizontal swipe. That was a big problem with the swipe feature. I'll take a look if there's a sensitivity function in the js that i can play around with. Otherwise I can probably show arrow buttons so the user knows to go forward or backwards, and get rid of the large black on hover boxes surrounding them. You preferred the swipe feature more than the click to navigate feature?

@esteinborn
Copy link
Member

Or you could re-calculate the height of the div after each swipe so that
you would be vertically scrolling the wholepage instead of just the framed
timeline piece.

and for goodness sakes please remove that lego pirate image.

On Mon, Apr 14, 2014 at 3:49 PM, extremezoo [email protected]:

@esteinborn https://github.com/esteinborn If i switch back to the
touch, I would have to figure out a way to prevent timelime plugin from
misinterpreting a vertical swipe from a horizontal swipe. That was a big
problem with the swipe feature. I'll take a look if there's a sensitivity
function in the js that i can play around with. Otherwise I can probably
show arrow buttons so the user knows to go forward or backwards, and get
rid of the large black on hover boxes surrounding them. You preferred the
swipe feature more than the click to navigate feature?


Reply to this email directly or view it on GitHubhttps://github.com//issues/113#issuecomment-40409843
.

@everett-f
Copy link

lol I was laughing at that, I don't know who put that there but I'll take it down. Okay I'll try what you suggested. Thanks for the help!

@everett-f everett-f self-assigned this Apr 15, 2014
@roshinc roshinc added this to the Final Draft milestone Apr 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants