Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Markdown Compatibility – Shortcode Tags {{ }} #1546

Open
7 tasks
isaaclombardssw opened this issue Oct 8, 2024 · 0 comments
Open
7 tasks

🩹 Markdown Compatibility – Shortcode Tags {{ }} #1546

isaaclombardssw opened this issue Oct 8, 2024 · 0 comments
Labels
TinaCMS Relates to TinaCMS migration

Comments

@isaaclombardssw
Copy link
Member

isaaclombardssw commented Oct 8, 2024

Pain

As discovered in #1525, {{ or }} (shortcode used to reference react components) throw errors when being parsed from markdown into the AST tree with the Tina parser.

We want to keep existing rules content so this should be possible in some way.

Suggested Solution

  • Confirm errors are thrown when the above markdown syntax is used with Tina.
  • Investigate if this is a known Tina issue or this is intended behaviour, if not, create a discussion or create a PBI in the TinaCMS repo.
  • Investigate what templates other than emails are being used in Rules markdown.
  • If necessary, add a Tina Template for email templates and other shortcode templates into the schema.
  • Add a react component to replace the email (and other) templates already in rules, with the same name as the template above.
  • Add the component into TinaMarkdown.
  • Convert all {{ }} instances in Rules into the Template syntax – or other solution to convert it from raw markdown prior to being parsed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TinaCMS Relates to TinaCMS migration
Projects
None yet
Development

No branches or pull requests

1 participant