Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 AdminUI | Leaderboard default column sort order is ascending #1166

Open
4 tasks
jernejk opened this issue Jan 23, 2025 · 0 comments
Open
4 tasks

🐛 AdminUI | Leaderboard default column sort order is ascending #1166

jernejk opened this issue Jan 23, 2025 · 0 comments
Labels
bug An issue with the system 🐛.

Comments

@jernejk
Copy link
Member

jernejk commented Jan 23, 2025

Cc: @vladislav-kir @wicksipedia @AntPolkanov @sethdaily @zacharykeeping

Hi @adamcogan,

Describe the Bug

At NDC Security conference while using a phone, Ben D noticed that leaderboard didn't appear to sort correctly.

There are 2 root causes for this:

  1. Default column sort is ascending instead of descending which would make more sense considering the use case
  2. On phone in portrait mode, the column sort is collapsed into a dropdown that does not allow you to sort a column descending

This issue would have been present in previous conferences but I assume we used a laptop or iPad where it was easy to spot and fix sort was ascending by clicking the column twice. (not an option on mobile in portrait mode but works in landscape)

To Reproduce

Steps to reproduce the behavior:

  1. On a phone in portrait mode, go to https://rewards.ssw.com.au/leaderboard
  2. Click on dropdown and select (e.g. "Points Today")
  3. See how the leaderboard appears incorrect and how we can't sort it in descending

Expected Behavior

We should default to descending sort for all columns that make sense.

Tasks

  • Investigate
  • Fix

Acceptance Criteria

More Information

There is an issue with the table component and we need to override default.

Environment

  • Device: iPhone, Android or any device with small enough width
  • OS: Any

Screenshots

Image

Thanks!

@jernejk jernejk added the bug An issue with the system 🐛. label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the system 🐛.
Projects
None yet
Development

No branches or pull requests

1 participant