Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test play selected segment at stream end regression with iOS/tvOS SDK 15.3 #115

Open
pyby opened this issue Mar 22, 2022 · 1 comment
Open

Test play selected segment at stream end regression with iOS/tvOS SDK 15.3 #115

pyby opened this issue Mar 22, 2022 · 1 comment
Labels
maintenance minor bug

Comments

@pyby
Copy link
Member

pyby commented Mar 22, 2022

Issue type

Incorrect behavior

Description of the problem

The testPlaySelectedSegmentAtStreamEnd test failed since we the project switch to Xcode 13.3.0.

Environment information

Last successful test on our CI is on feature/playback-speed branch 3ad9fd5623ceafeed4187751b0c06e65783430e0: Xcode 13.2.1, iOS base SDK 15.2, Mac OS 11.3.0.

Next test failed on our CI, f63ba8c49ec32f54fb3b8617fe187eeddc2da83b on same branch: Two new commit "Update track settings icon" and "Update popover title" has no impact on the controller:

testPlaySelectedSegmentAtStreamEnd: Xcode 13.3.0, iOS base SDK 15.3, Mac OS 12.2.1.

  • Library version: Any
  • iOS / tvOS version: Any
  • Device: Any

Reproducibility

Always reproducible

Steps to reproduce

  1. Run testPlaySelectedSegmentAtStreamEnd test.
@pyby
Copy link
Member Author

pyby commented Mar 22, 2022 •
edited
Loading

The SRGMediaPlayerSegmentDidEndNotification notification is not fired anymore with iOS 15.3 SDK.
With Xcode 13.3.0, in Simulator, iOS 14.5 SDK, the test passes.

it looks like an iOS 15.3 regression.

pyby added a commit that referenced this issue Mar 22, 2022
@pyby
Disable regression test on iOS 15.3 (#115)
6493e8d
@pyby pyby changed the title Test play selected segment at stream end regression with Xcode 13.3.0 Test play selected segment at stream end regression with iOS/tvOS SDK 13.3.0 Mar 22, 2022
@pyby pyby changed the title Test play selected segment at stream end regression with iOS/tvOS SDK 13.3.0 Test play selected segment at stream end regression with iOS/tvOS SDK 13.3 Mar 22, 2022
@pyby pyby changed the title Test play selected segment at stream end regression with iOS/tvOS SDK 13.3 Test play selected segment at stream end regression with iOS/tvOS SDK 15.3 Mar 22, 2022
@pyby pyby mentioned this issue Mar 22, 2022
Closed
@defagos defagos modified the milestone: 6.3.0 Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance minor bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@defagos @pyby