New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some questions for the code #2

Open

Andy-zd opened this issue Jun 16, 2022 · 0 comments

Andy-zd commented Jun 16, 2022 •

edited

Loading

So appreciative of you to provide the code for your algorithm. There are some questions for me when following your algorithm.

1. The area and delay variables seem not to get connected correctly with the variables b. https://github.com/SJTU-ECTL/GOMIL/blob/master/src/Adder_Tree_Optimization.cpp#L131 conflicts with the formulation in the paper. If this happens, the adder and multiplication will be divided separately, which leads to an unexpected solution.

2. Some wrong parameters settings.

(1) The https://github.com/SJTU-ECTL/GOMIL/blob/master/src/main.cpp#L129 and https://github.com/SJTU-ECTL/GOMIL/blob/master/src/main.cpp#L91 take different proportion for full adders and half adders.

(2) The default settings of parameter W and L differ with the settings in the paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment