Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dlite.Instance.from_dict() to correctly parse ref-type properties #983

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix dlite.Instance.from_dict() to correctly parse ref-type properties #983

wants to merge 9 commits into from

Conversation

jesper-friis
Copy link
Collaborator

Description

This should make it possible to correctly parse YAML files with ref-type properties.

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@jesper-friis jesper-friis linked an issue Oct 25, 2024 that may be closed by this pull request
Ref-type doesn't work with YAML #982
Open
francescalb
francescalb reviewed Oct 25, 2024
View reviewed changes
bindings/python/tests/test_ref_type.py Outdated
Top = dlite.get_instance("http://onto-ns.com/meta/0.1/Top")
Middle = dlite.get_instance("http://onto-ns.com/meta/0.1/Middle")
Middle = dlite.get_instance("http://onto-ns.com/meta/0.2/Middle")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should still test json as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are still testing JSON, since all the other datamodels are read from input/test_ref_type.json.

francescalb
francescalb reviewed Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reading the yaml version only available in python?

@jesper-friis
Copy link
Collaborator Author

I reading the yaml version only available in python?

Sorry, unsure what you mean here? The YAML plugin is written in Python, but it is still be used from C via the embedded interpreter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescalb francescalb francescalb left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ref-type doesn't work with YAML
2 participants
@jesper-friis @francescalb