Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up property situation in NetworkPlan #63

Open
vr2262 opened this issue Apr 28, 2016 · 5 comments
Open

Clean up property situation in NetworkPlan #63

vr2262 opened this issue Apr 28, 2016 · 5 comments
Assignees
@vr2262

Comments

@vr2262
Copy link
Contributor

vr2262 commented Apr 28, 2016

See #62 (comment)
@vr2262 vr2262 self-assigned this Apr 28, 2016
@vr2262 vr2262 mentioned this issue Apr 28, 2016
Merged
vr2262 added a commit that referenced this issue Apr 28, 2016
@vr2262
Clean up properties that don't need to be properties
7427cea 
Fixes #63
vr2262 added a commit that referenced this issue Apr 29, 2016
@vr2262
Clean up properties that don't need to be properties
4a69561 
Fixes #63
@vr2262
Copy link
Contributor Author

vr2262 commented Apr 29, 2016

@chrisnatali nice branch for this right here: https://github.com/SEL-Columbia/Sequencer/compare/vr2262-issue-63-properties

Are you going to make a release branch or should i make a PR into master?

@vr2262
Copy link
Contributor Author

vr2262 commented May 2, 2016

@chrisnatali

@chrisnatali
Copy link
Contributor

The point is that properties are not justified here?

@vr2262
Copy link
Contributor Author

vr2262 commented May 3, 2016

Yes, they don't get you anything (and you can always go back if you want).

@chrisnatali
Copy link
Contributor

Good. PR is fine, though I don't see this as a priority. We can release this if another urgent fix comes up. Otherwise, I think more broad issues like #64 & #65 should be the focus now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vr2262 vr2262

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisnatali @vr2262