Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodes should be indexed by integers throughout #59

Open
chrisnatali opened this issue Apr 25, 2016 · 2 comments
Open

nodes should be indexed by integers throughout #59

chrisnatali opened this issue Apr 25, 2016 · 2 comments

Comments

@chrisnatali
Copy link
Contributor

Related to findings in #57, When we have 'fake' nodes, the 'Sequence..Upstream.id' field in the results dataframe appears to become a float64 type see this. That field references a node and it's inaccurate for it to be a float64.

Maybe we need to represent "fake" nodes with negative values
@vr2262
Copy link
Contributor

vr2262 commented Apr 27, 2016

A possibility: #57 (comment)

@chrisnatali chrisnatali mentioned this issue Apr 28, 2016
Merged
chrisnatali added a commit that referenced this issue Apr 29, 2016
@chrisnatali
Merge pull request #62 from SEL-Columbia/vr2262-issue-57-float-index-…
c18d663 
…with-guard

Redoing PR for fixes #57 and #60 (and maybe #59)
@vr2262
Copy link
Contributor

vr2262 commented May 2, 2016

@chrisnatali
Is this done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisnatali @vr2262