NuMIEXTRetriever subrun warning message

[miquelnebot]

''' /exp/sbnd/app/users/mnebot/sbnbuild/BuildAreas/v09_82_02_sbn_26.01.2024_060702/srcs/sbncode/sbncode/BeamSpillInfoRetriever/NuMIEXTRetriever/NuMIEXTRetriever_module.cc: In member function 'virtual void sbn::NuMIEXTRetriever::endSubRun(art::SubRun&)':
/exp/sbnd/app/users/mnebot/sbnbuild/BuildAreas/v09_82_02_sbn_26.01.2024_060702/srcs/sbncode/sbncode/BeamSpillInfoRetriever/NuMIEXTRetriever/NuMIEXTRetriever_module.cc:150:9: warning: 'art::PutHandle art::SubRun::put(std::unique_ptr<_Tp>&&, const std::string&) [with PROD = std::vectorsbn::EXTCountInfo; std::string = std::__cxx11::basic_string]' is deprecated: \n\nart warning: The SubRun::put(...) function without a product semantic is deprecated.\n Please adjust your usage to include the correct semantic (e.g.):\n\n subrun.put(move(product), art::fullSubRun());\n subrun.put(move(product), instanceName, art::subRunFragment());\n\n Generally, SubRun::put calls made in beginSubRun should include art::fullSubRun();\n SubRun::put calls made in endSubRun should use art::subRunFragment().\n Contact [email protected] for assistance or details.\n\n [-Wdeprecated-declarations]
150 | sr.put(std::move(p));
| ~~~~~~^~~~~~~~~~~~~~
In file included from /cvmfs/larsoft.opensciencegrid.org/products/art/v3_12_00/include/art/Framework/Principal/Event.h:15,
from /exp/sbnd/app/users/mnebot/sbnbuild/BuildAreas/v09_82_02_sbn_26.01.2024_060702/srcs/sbncode/sbncode/BeamSpillInfoRetriever/NuMIEXTRetriever/NuMIEXTRetriever_module.cc:12:
/cvmfs/larsoft.opensciencegrid.org/products/art/v3_12_00/include/art/Framework/Principal/SubRun.h:126:3: note: declared here
126 | SubRun::put(std::unique_ptr&& edp, std::string const& instance)
| ^~~~~~
'''

[jzennamo]

OK, so I took a look and compared it to the BNB version of the package and I tried to replicate all the differences to see if any of them would make this warning go away but that didn't work.

Big picture we don't see this warning with the BNB packages and I do not understand why...

[jzennamo]

Also, I added @brucehoward-physics

[jzennamo]

Obviously, I was editing the wrong module....

Bruce set me straight and I'll try this again

[jzennamo]

OK it looks like there needs to be a simple change made:

sr.put(std::move(p));

needs to change to:

sr.put(std::move(p), art::subRunFragment());

I'll put this into a PR.

[jzennamo]

Here you go:
#416

[ibsafa]

This issue has a linked PR that was merged. @jzennamo can you confirm this is no longer an issue so i can go ahead and close it? thanks!