Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split CAFMaker into record-making and CAF-making parts #219

Open
cjbacchus opened this issue Dec 17, 2021 · 1 comment
Open

Split CAFMaker into record-making and CAF-making parts #219

cjbacchus opened this issue Dec 17, 2021 · 1 comment

Comments

@cjbacchus
Copy link
Contributor

CAFMaker does (at least) two things

  1. Summarizes art level information into StandardRecord objects
  2. Writes those objects to an output TFile (the CAF)

This issue is to split the two parts into separate modules (StandardRecordMaker and CAFMaker?) that would usually run one after the other, reproducing the current behaviour, but also enabling some other modes of operation.

The records from 1. would be communicated to 2. by writing them into the art record. That is already happening, they are simply immediately dropped because we don't configure an art output file.

Probably this is a little more complicated than I have made it sound, due to things done at the run/subrun level (I think 1. should write an SRGlobal product to be written by 2. for example), metadata, etc. The only way to find all these intertwined places is to try and separate them. The sooner this is done, the less untangling there will be to do.

@wesketchum
Copy link
Contributor

sorry, probably not right to close....right @cjbackhouse ?

@wesketchum wesketchum reopened this Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants