Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimEnergyDeposit Collections in new LArG4 #185

Open
1 of 2 tasks
marcodeltutto opened this issue Nov 5, 2021 · 4 comments · Fixed by SBNSoftware/sbndcode#206
Open
1 of 2 tasks

SimEnergyDeposit Collections in new LArG4 #185

marcodeltutto opened this issue Nov 5, 2021 · 4 comments · Fixed by SBNSoftware/sbndcode#206
Assignees
Labels
enhancement New feature or request

Comments

@marcodeltutto
Copy link
Member

marcodeltutto commented Nov 5, 2021

With the new LArG4, there is a proliferation of saved SimEnergyDeposit collections, as shown in the image below. We have:

  • 7 SimEnergyDeposits created directly by LArG4: 1 for the Active Volume and 6 for volumes outside the AV
  • 3 SimEnergyDeposits created by ionandscint: 2 for the AV (one w/ and one w/o SCE) and 1 for outside the AV. The one in AV w/ SCE is already dropped.

The proposal discussed in previous meetings was to also drop the 7 SimEnergyDeposits created directly by LArG4. @jzennamo @wesketchum Shall I proceed with this?

To be done for:

  • SBND
  • ICARUS

New G4 Workflow drawio

@wesketchum
Copy link
Contributor

I say yes.

Only thing is to verify/maybe even test that SimEdeps w/o SCE offsets can properly be used as input to ionandscint In AV/Out AV? If that is the case, then think this is perfect.

Honestly, I'd accept verbal confirmation, but if someone actually did run it through as a check even better.

@wesketchum
Copy link
Contributor

@marcodeltutto please assign someone (possibly yourself) to do this/keep track of this.

@marcodeltutto marcodeltutto self-assigned this Nov 5, 2021
@marcodeltutto
Copy link
Member Author

Thanks @wesketchum! Feeding SimEnergyDeposits w/o SCE offsets was tested by @VCLanNguyen here SBNSoftware/sbndcode#195 (comment).

@wesketchum
Copy link
Contributor

Keeping this open to remind us we need to do this for ICARUS when they switch to the new LArG4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants