From 96544efc188185dd6f072733049a3cb64b8144e1 Mon Sep 17 00:00:00 2001 From: TeodorTaushanov Date: Wed, 21 Aug 2024 09:25:20 +0300 Subject: [PATCH] fix(ui5-dialog): fix block layer of initially opened dialog (#9715) fix(ui5-dialog): fix block layer of initially opened dialog --- packages/main/src/Popup.ts | 4 ++ .../main/test/pages/DialogInitiallyOpen.html | 41 +++++++++++++++++++ packages/main/test/specs/Dialog.spec.js | 10 +++++ 3 files changed, 55 insertions(+) create mode 100644 packages/main/test/pages/DialogInitiallyOpen.html diff --git a/packages/main/src/Popup.ts b/packages/main/src/Popup.ts index 22cf3aea0693..06173ee1f913 100644 --- a/packages/main/src/Popup.ts +++ b/packages/main/src/Popup.ts @@ -252,6 +252,10 @@ abstract class Popup extends UI5Element { } this.tabIndex = -1; + + if (this.open) { + this.showPopover(); + } } onExitDOM() { diff --git a/packages/main/test/pages/DialogInitiallyOpen.html b/packages/main/test/pages/DialogInitiallyOpen.html new file mode 100644 index 000000000000..c54beab877a9 --- /dev/null +++ b/packages/main/test/pages/DialogInitiallyOpen.html @@ -0,0 +1,41 @@ + + + + + + + + Dialog + + + + + + + + + + + + + + diff --git a/packages/main/test/specs/Dialog.spec.js b/packages/main/test/specs/Dialog.spec.js index 32717f1a3f24..c6c2857fa938 100644 --- a/packages/main/test/specs/Dialog.spec.js +++ b/packages/main/test/specs/Dialog.spec.js @@ -744,3 +744,13 @@ describe("Block layers", () => { await browser.keys("Escape"); }); }); + +describe("Dialog initially open", () => { + before(async () => { + await browser.url(`test/pages/DialogInitiallyOpen.html`); + }); + + it("test :popover-open selector", async () => { + assert.ok(await browser.$("#dialogOpen").matches(":popover-open"), "popover is opened correctly"); + }); +});