Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Make ClassLoader optional argument for service loading #73

Open
newtork opened this issue Nov 14, 2022 · 0 comments
Open

Feat: Make ClassLoader optional argument for service loading #73

newtork opened this issue Nov 14, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@newtork
Copy link
Contributor

newtork commented Nov 14, 2022

Context

The method ServiceBindingAccessor.getInstancesViaServiceLoader() uses service loader pattern.

By default the class' class loader will be used: ServiceBindingAccessor.class.getClassLoader(). There is now way to customize.

Request

Allow optional parameter ClassLoader for serivce loader API usage.

Suggestions

Overload method ServiceBindingAccessor.getInstancesViaServiceLoader(ClassLoader).

Questions

  • Why?
    • For service loader pattern we've noticed issues with different class loaders and issues with casting classes between them. This method would be useful in case of troubleshooting. Otherwise, I find these problems are almost impossible to debug.
  • What are the use cases?
    • Multiple or different versions per classloader, e.g. via buildpack and via application binary.
@newtork newtork added the enhancement New feature or request label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant