Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematron currently checks if the content in <agencyCode> is compliant with ISO 15511 even if @repositoryEncoding is not set #10

Open
2 of 9 tasks
kerstarno opened this issue Mar 19, 2024 · 5 comments
Assignees
Labels
EAC schematron This issue relates to the EAC schematron EAD major revision (EAD 4.0) This issue is part of the EAD major revision towards EAD 4.0 EAD schematron This issue relates to the EAD schematron Enhancement This issue describes an enhancement to current descriptions or examples Review This is being reviewed in order to decide whether it will be implemented Shared schematron This issue relates to shared schematron rules

Comments

@kerstarno
Copy link
Contributor

Creator of issue

  1. Kerstin Arnold
  2. EAD team lead, TS-EAS
  3. @kerstarno
  4. [email protected]

The issue relates to

  • EAC-CPF schema issue
  • EAC-CPF Tag Library issue
  • EAD schema issue
  • EAD Tag Library issue
  • Schema issue
  • Tag Library issue
  • Suggestions for all schemas
  • Suggestions for all Tag Libraries
  • Other

Wanted change/feature

  • Text: This might be a similar remnant from EAD3 Schematron rules as requiring ISO 8601 compliant dates even if @dateEncoding isn't set (see We currently don't have any special tests for unitDate in the same way we do for the single date elements (date, fromDate, toDate) #7). At the moment, in both the XSD and the RNG (when used with Schematron), there seems to be a check for the content of <agencyCode> to be compliant with ISO 15511, so that the following error message is shown even if @repositoryEncoding isn't set (yet) in <control>: "If the repositoryEncoding is set to ISO 15511, then the format of the value of the agencyCode element is constrained to that of the International Standard Identifier for Libraries and Related Organizations (ISIL: ISO 15511): a prefix, a hyphen, and an identifier."
  • This message should only be shown, if @repositoryEncoding is present and is indeed used with the value "iso15511".
@fordmadox
Copy link
Member

That was the decision made for the EAC CPF 2.0 release (ditto for the default of ISO 8601, which was also present in EAD3). I will update the 'ead4' branch for this decision, but since it differs from the EAC decision, I'll also add Marie to this ticket for future review.

@fordmadox
Copy link
Member

fordmadox commented Mar 21, 2024

Same for script and country codes, since those lists were always the de-facto defaults, and so, didn't need to be specified.

But for this issue, I'm just updating the repositoryEncoding test.

@fordmadox
Copy link
Member

@kerstarno kerstarno moved this from In Progress to Ready for testing in Major EAD revision Mar 22, 2024
@kerstarno
Copy link
Contributor Author

Re-tested with the XSD and the RNG (with the "ead4" branch Schematron) and can confirm that the check is now only done when @repositoryEncoding is used/present in <control> and has the value "iso15511".

Will admit that I didn't remember that decision from the EAC-CPF revision anymore. I think, what mainly made me wonder was the fact that the messaged starts with "If the repositoryEncoding is set to ISO 15511...". As long as I haven't used the @repositoryEncoding attribute to start with, that message seems off. The same for @countryCode, @scriptCode, and @scriptOfElement. As long as I don't have the respective @...Encoding attributes added to <control>, the error message can't - to my mind - require the value of these attributes to follow a specific ISO code (or EAS list). The first message to show in that case should - again, to my mind - rather be something like "Please add @...Encoding to <control> and specify the code list that the values of @[name of the attribute in question] are expected to follow."

@kerstarno kerstarno moved this from Ready for testing to Merged in Major EAD revision Mar 22, 2024
@fordmadox
Copy link
Member

Agreed. I think that all the Schematron messages should be reviewed and updated!!! Most were just added as a quick example.

@kerstarno kerstarno added Enhancement This issue describes an enhancement to current descriptions or examples Review This is being reviewed in order to decide whether it will be implemented EAD schematron This issue relates to the EAD schematron EAC schematron This issue relates to the EAC schematron Shared schematron This issue relates to shared schematron rules EAD major revision (EAD 4.0) This issue is part of the EAD major revision towards EAD 4.0 labels May 3, 2024
@kerstarno kerstarno moved this from Merged to Review in Major EAD revision May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EAC schematron This issue relates to the EAC schematron EAD major revision (EAD 4.0) This issue is part of the EAD major revision towards EAD 4.0 EAD schematron This issue relates to the EAD schematron Enhancement This issue describes an enhancement to current descriptions or examples Review This is being reviewed in order to decide whether it will be implemented Shared schematron This issue relates to shared schematron rules
Projects
Status: Review
Development

No branches or pull requests

3 participants