Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration for p/blockquote to p/quote problematic #45

Open
rockivist opened this issue Nov 1, 2015 · 2 comments
Open

Migration for p/blockquote to p/quote problematic #45

rockivist opened this issue Nov 1, 2015 · 2 comments
Labels

Comments

@rockivist
Copy link
Member

My test on the Yale EAD set showed two issues with this.

  1. When there are multiple paragraphs in the blockquote, all that formatting is lost. Not necessarily a cause of validation issues, but its a notable loss.

  2. quote only contains mixed basic, so title and other control access elements valid in paragraph don't validate post-migration.

I'll look a the p/blockquote migration and see if I can tweak it a bit. Kinda surprised we haven't encountered this yet in testing.

@rockivist rockivist added the bug label Nov 1, 2015
@rockivist rockivist self-assigned this Nov 1, 2015
@rockivist
Copy link
Member Author

Note to myself: test against mssa.ru.0151.xml

@rockivist
Copy link
Member Author

I poked at this for a bit but didn't come up with a satisfying improvement. I'm going to leave as is in the current version. I'll keep the issue open in case anyone comes looking. We'll see if we hear from people about this. Hopefully it's an edge case.

@rockivist rockivist removed their assignment Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant