You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should we forward the error received inside the CLGeocodeCompletionHandler? It was not done before, however all methods on CLGeocoder have the following notice:
After initiating a forward-geocoding request, do not attempt to initiate another forward- or reverse-geocoding request. Geocoding requests are rate-limited for each app, so making too many requests in a short period of time may cause some of the requests to fail. When the maximum rate is exceeded, the geocoder passes an error object with the value CLError.Code.network to your completion handler.
It looks like danger now requires the change log. You can add a CHANGELOG.md file detailing your changes in this MR. Please also add it to the Readme.md
For tests you can see examples in RxCoreLocationSpec we use quick and nimble for testing
Yes it would be nice to forward the error from CLGeocodeCompletionHandler
Added a CHANGELOG.md file, however I'm unsure if that is the problem.
A quick googling lead me to this issue: Github Enterprise: "context.github.repos.getContents is not a function" repository-settings/app#123
I am not sure if it's related, but based on that, I would assume danger.github.api.repos.getContent needs to be changed to danger.github.api.repos.getContents, since the getContent function got removed.
It seems to be coming from here: https://github.com/RxSwiftCommunity/peril and it's run on every PR for repositories under RxSwiftCommunity.
I could not find any PRs that passed the check :|
Yep, that was the problem. It got fixed.
Yes, I noticed Quick and Nimble are being used. However, the current tests have no asynchronous behavior by the looks of it. I would need to mock out the baseCLLocation.
Or should I add some toEventually behavior?
Added tests using toEventually, however I was getting the following error when running the tests: MobileGestalt.c:1647: Could not retrieve region info
Google suggested it's because it's ran on a simulator rather than real device.
Using the .gpx file is supposed to fix it, however I didn't manage to get it working.
If you have any ideas how to fix it, I would appreciate some suggestions :)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36
I'm unsure of a few things:
CLGeocodeCompletionHandler? It was not done before, however all methods on CLGeocoder have the following notice: