Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve wrapper around CLGeocoder? #36

Open
lordzsolt opened this issue Sep 14, 2020 · 2 comments
Open

Retrieve wrapper around CLGeocoder? #36

lordzsolt opened this issue Sep 14, 2020 · 2 comments

Comments

@lordzsolt
Copy link
Member

lordzsolt commented Sep 14, 2020

I noticed, with the current implementation, all the placemark methods internally create an instance of CLGeocoder.

I would like to ask, what is your opinion on exposing them publicly, and putting a Reactive extension on CLGeocoder?
I don't mind doing it myself, so long as the idea gets approved.

Benefits would be that you can do reverse geocoding on any CLLocation, not just the user's current location.

@bobgodwinx
Copy link
Member

I think it's a good idea. 👍🏾
Do you have a PR for this ?

@lordzsolt
Copy link
Member Author

I will get one ready this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants