Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot specify a Group as the actor when initializing by URL #111

Open
frasern opened this issue Jun 29, 2015 · 4 comments
Open

Cannot specify a Group as the actor when initializing by URL #111

frasern opened this issue Jun 29, 2015 · 4 comments

Comments

@frasern
Copy link

frasern commented Jun 29, 2015

At present, _initFromQueryString always assumes the actor parameter is an Agent, and simply ignores the objectType property if present. This means using a Group doesn't work as expected.

If the objectType property is present and set to "Group", the actor should be instantiated as a Group instead of an Agent.

frasern added a commit to frasern/TinCanJS that referenced this issue Jun 29, 2015
@frasern
Copy link
Author

frasern commented Jun 29, 2015

Pull request created: #112

@garemoko
Copy link
Contributor

Thanks for flagging this and for creating a PR. The launch spec is silent on whether groups should be supported, but I see no reason why we shouldn't.

I'm interested to know your use case?

@frasern
Copy link
Author

frasern commented Jun 29, 2015

Our training is sometimes going to be used in a classroom setting with a projector/big screen. In such cases we plan to use the Group functionality to record statements against the set of trainees present in the class.

@garemoko
Copy link
Contributor

Thanks for sharing. I imagine that's not an uncommon use case actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants