Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images fixes #64

Open
bjones1 opened this issue May 25, 2021 · 6 comments
Open

Images fixes #64

bjones1 opened this issue May 25, 2021 · 6 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bjones1
Copy link
Contributor

bjones1 commented May 25, 2021

I spent some time reviewing the new webpack-based approach for the Runestone Components to ensure all the images are correctly included. I see two problems we need to address:

  1. The clock image used for timed questions doesn't render properly. I think it would be best to assign this to a style, then add CSS to reference the image directly. See all instances of ../_static/clock.png in the timed_xxx.js files, and the source image in runestone/common/project_template/_static. I'd suggest moving this to runestone/common/css then modifying the CSS these.
  2. The play overlay icon at https://github.com/RunestoneInteractive/RunestoneComponents/blob/master/runestone/common/js/bookfuncs.js#L285. This relies on web2py templates to render, so it's already a non-starter for pretext. Again, put this in CSS then just set a style, I would think.

I'm not aware of any other missing images.

@bnmnetp bnmnetp self-assigned this Jun 5, 2021
@bnmnetp bnmnetp added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 7, 2021
@bnmnetp
Copy link
Member

bnmnetp commented Jun 7, 2021

  1. The solution is to include the clock.png image in the webpack bundle for timed questions and use a CSS class to show or not show that image.
  2. Lines 280-287 are not used anywhere anymore. They can be removed.

@zachneill
Copy link

@Bekjon777 and I are working on this (Berea College students)

@Bekjon777
Copy link

Does the clock image have to be shown to all types of timed questions?

@bnmnetp bnmnetp transferred this issue from RunestoneInteractive/RunestoneComponents Jun 7, 2023
@thaopham03
Copy link

@njounkengdaizem and I are working again on this issue.

@thaopham03
Copy link

@bnmnetp Hello Brad, does this relate to webwork questions or Runestone timed exams?

@daizenj
Copy link
Contributor

daizenj commented Nov 9, 2023

@bnmnetp we see former students attempted a fix to this bug with this PR RunestoneInteractive/RunestoneComponents#1276

Do you want us to do anything different? Their PR was never reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants