Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usernames with emojis in them cause trouble in Student Progress report #192

Open
irunestone opened this issue Jan 17, 2018 · 4 comments · May be fixed by #443
Open

usernames with emojis in them cause trouble in Student Progress report #192

irunestone opened this issue Jan 17, 2018 · 4 comments · May be fixed by #443
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@irunestone
Copy link

irunestone commented Jan 17, 2018 •
edited by bnmnetp
Loading

Error reported in course SB_Intro_CS_Python on page /runestone/dashboard/studentreport?id=G%C3%83%C2%A4g%C3%84%C2%99%C3%B0%C2%9F%C2%99%C2%8C by user MrsJakubielski
Please describe what you were doing that led up to this error:
I am trying to access a specific student's info: Gage Goodwin and every time I click on his name I get directed to report a bug. I seem to be able to access all the other students info except his.

---------------- Traceback --------------
Traceback (most recent call last):
File "/home/bmiller/Runestone/web2py/gluon/restricted.py", line 219, in restricted
exec(ccode, environment)
File "/home/bmiller/Runestone/web2py/applications/runestone/controllers/dashboard.py", line 286, in
File "/home/bmiller/Runestone/web2py/gluon/globals.py", line 409, in
self._caller = lambda f: f()
File "/home/bmiller/Runestone/web2py/gluon/tools.py", line 3964, in f
return action(*a, **b)
File "/home/bmiller/Runestone/web2py/applications/runestone/controllers/dashboard.py", line 150, in studentreport
data_analyzer.load_user_metrics(request.vars.id)
File "/home/bmiller/Runestone/web2py/applications/runestone/models/db_dashboard.py", line 368, in load_user_metrics
self.db_chapter_progress = db((db.user_sub_chapter_progress.user_id == self.user.id)).select(db.user_sub_chapter_progress.chapter_id,db.user_sub_chapter_progress.sub_chapter_id,db.user_sub_chapter_progress.status)
AttributeError: 'NoneType' object has no attribute 'id'
@bnmnetp
Copy link
Member

bnmnetp commented Jan 17, 2018

Yes, young gage seems to have created a very creative username: Gägę🙌

This is not supported, but I suppose we should try to detect that at registration time.

@bnmnetp bnmnetp changed the title Accessing Student info usernames with emojis in them cause trouble in Student Progress report Jan 18, 2018
@bnmnetp bnmnetp added help wanted Extra attention is needed good first issue Good for newcomers labels Jan 18, 2018
@bnmnetp
Copy link
Member

bnmnetp commented Jan 18, 2018

Write a javascript validation function to ensure that a username has only ascii characters in it before submitting a registration request.

@knakaj
Copy link

knakaj commented Jul 28, 2022

I have started working on solving this issue and it is not clear which characters should be prevented to avoid the trouble. I have tried different usernames, where the ones with emojis always cause troubles, but some usernames that had non-ASCII characters worked and some did not. Any clarification on which characters should be allowed would be appreciated @bnmnetp @bjones1 .

@bnmnetp bnmnetp transferred this issue from RunestoneInteractive/RunestoneComponents Jun 7, 2023
@AnishKharel
Copy link

I am gonna pick this up.

@andersoncedu andersoncedu linked a pull request Dec 7, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue192 Emojis in Usernames andersoncedu/rs
4 participants
@bnmnetp @irunestone @AnishKharel @knakaj