Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Keyboard shortcuts are not working #34178

Open
thepiyush-303 opened this issue Dec 14, 2024 · 6 comments · May be fixed by #34181 or #34179
Open

Some Keyboard shortcuts are not working #34178

thepiyush-303 opened this issue Dec 14, 2024 · 6 comments · May be fixed by #34181 or #34179
Labels
Tasked Added to the internal issue tracking

Comments

@thepiyush-303
Copy link
Contributor

Description:

Any room in Rocket -> Options -> Keyboard Shortcuts

these are not working as expected
image

Expected behavior:

when using UpArrow Key with Alt the text cursor should move to the starting point from where text is started but it does not move same with DownArrow
and RightArrow and DownArrow also not working

Actual behavior:

The shortcut should work as documented

Server Setup Information:

  • Version of Rocket.Chat Server: 7.2.0
  • License Type:
  • Number of Users: 2
  • Operating System: Ubuntu
  • Deployment Method: development
  • Number of Running Instances: 2
  • DB Replicaset Oplog:
  • NodeJS Version: 20.18.0
  • MongoDB Version:

Client Setup Information

  • Desktop App or Browser Version: FireFox, Chrome
  • Operating System: Ubuntu 24

Additional context

Relevant logs:
@thepiyush-303 thepiyush-303 linked a pull request Dec 14, 2024 that will close this issue
Open
@Kartikayy007
Copy link

Hey, @thepiyush-303
I have tested the keyboard shortcuts (ArrowLeft, ArrowRight, and Escape) on all major browsers (Safari, Firefox, and Chrome) on my device, and they are working as expected. The behavior aligns with the intended functionality of navigating through slides and closing the carousel.

It’s possible that the issue might be specific to certain environments, browser configurations, or operating systems (e.g., Ubuntu or specific Chrome settings). To investigate further, I recommend:
1. Testing on the reported setup (Ubuntu 24 with Chrome/Firefox).
2. Checking for any browser extensions or custom settings that might interfere with keyboard events.

Please let me know if additional tests or logs are required! 🚀

@thepiyush-303
Copy link
Contributor Author

It can be reproduced on ubuntu
Did you check on it?

@Kartikayy007
Copy link

Fixes #34181

@Kartikayy007 Kartikayy007 linked a pull request Dec 15, 2024 that will close this issue
Open
@thepiyush-303
Copy link
Contributor Author

thepiyush-303 commented Dec 15, 2024 •
edited
Loading

There is already a PR There is no need to create a New PR

@reetp
Copy link

reetp commented Dec 16, 2024

I have tested the keyboard shortcuts
they are working as expected

So why if your (looks like AI generated) response says "working as expected" have you done this?

Fixes #34181

Please do not start working on issues that already have a PR.

Find your own issue to solve.

Thanks.

@reetp reetp added the Tasked Added to the internal issue tracking label Dec 18, 2024
@casalsgh
Copy link
Contributor

asking team to check the issue and review pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tasked Added to the internal issue tracking
Projects
None yet
Milestone
No milestone
5 participants
@reetp @casalsgh @Kartikayy007 @thepiyush-303 and others