Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(messages): support multi-parameter sorting for IM/DM messages #34009

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(messages): support multi-parameter sorting for IM/DM messages #34009

wants to merge 2 commits into from

Conversation

MahmoudMowiena
Copy link

@MahmoudMowiena MahmoudMowiena commented Nov 20, 2024 •
edited by jira bot
Loading

Previously, the sorting for IM/DM messages relied only on the ts timestamp. This fix updates the logic to allow sorting by multiple parameters, similar to group messages, enhancing consistency across message types.

Closes #34008
CORE-830

@MahmoudMowiena
fix(messages): support multi-parameter sorting for IM/DM messages
df5ed1d 
Previously, the sorting for IM/DM messages relied only on the `ts` timestamp.
This fix updates the logic to allow sorting by multiple parameters, similar
to group messages, enhancing consistency across message types.

Closes RocketChat#34008
@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 20, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.2.0, but it targets 7.1.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@scuciatto scuciatto added this to the 7.2.0 milestone Nov 26, 2024
MarcosSpessatto
MarcosSpessatto requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add a changeset for this change. And I think this is more a feat than a fix

apps/meteor/app/api/server/v1/im.ts Outdated Show resolved Hide resolved
@MahmoudMowiena
A default sorting parameter is provided in case no sorting parameter …
0a96cc4 
…was provided, which is by ts in descending order. A test case has been added as well to the test suite ensuring that the messages fetched adhere to the sorting parameter provided.
@MahmoudMowiena MahmoudMowiena requested a review from a team as a code owner December 1, 2024 22:31
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2024

⚠️ No Changeset found

Latest commit: 0a96cc4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosSpessatto MarcosSpessatto MarcosSpessatto requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.

IM/DM messages sorting relies only on ts, unlike group messages
4 participants
@MahmoudMowiena @CLAassistant @MarcosSpessatto @scuciatto