Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded "pdf" path from IIIF asset base url #596

Open
ctgraham opened this issue Jun 18, 2024 · 0 comments
Open

Remove hardcoded "pdf" path from IIIF asset base url #596

ctgraham opened this issue Jun 18, 2024 · 0 comments
Assignees

Comments

@ctgraham
Copy link
Contributor

ctgraham commented Jun 18, 2024

Is your feature request related to a problem? Please describe.

We would like to allow digital objects to be rendered from an arbitrary IIIF endpoint, but the code currently hardcodes the IIIF endpoint in the form of:
settings.ASSET_BASEURL + "/pdfs/" + identifier

req = requests.head("{}/pdfs/{}".format(settings.ASSET_BASEURL.rstrip("/"), identifier))

Describe the solution you'd like

Move the "/pdfs/" reference to the ASSET_BASEURL setting.

Describe alternatives you've considered

Since we are checking on assets which we expect to render in an IIIF viewer, perhaps the check should ultimately be for the IIIF manifest rather than a HTTP HEAD of the IIIF viewer?

Or perhaps it would be better to split this into two settings: ASSET_BASEURL and ASSET_BASEPATH, considering "Additional context" for DIMES?

Additional context

This may have implications for the setting of REACT_APP_S3_BASEURL in DIMES as well? DIMES cannot include the "/pdf/" route as part of the setting because it also needs the "/manifest/" route. Is there value in aligning ASSET_BASEURL from pisces with REACT_APP_S3_BASEURL in DIMES?

@helrond helrond self-assigned this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants