Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped catkin tests #329

Open
nicolecheetham opened this issue Oct 21, 2024 · 4 comments
Open

Skipped catkin tests #329

nicolecheetham opened this issue Oct 21, 2024 · 4 comments
Assignees

Comments

@nicolecheetham
Copy link
Collaborator

Currently, the catkin installed job successfully runs however it skips all of its tests.

Agenda:

  1. Check if other examples' tests are skipped
  2. Investigate whether the job(s) always had skipped tests or if the DEE refactoring caused the tests to be skipped
@nicolecheetham
Copy link
Collaborator Author

nicolecheetham commented Oct 23, 2024

PR 328 first brought up this issue.

@nicolecheetham
Copy link
Collaborator Author

nicolecheetham commented Oct 23, 2024

  • catkin_installed does not run tests
  • ament_cmake_installed runs a test executable (does not mention specific tests when run)
    When failures/bugs are introduced in one of the tests, the build output will state test failures occurred but the job will still be green.

Ament error build test output:

--- stderr: drake_ament_cmake_installed
Errors while running CTest
Output from these tests are in: /__w/drake-external-examples/drake-external-examples/drake_ament_cmake_installed/build/drake_ament_cmake_installed/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
---
Finished <<< drake_ament_cmake_installed [0.70s]	[ with test failures ]

The rest of the examples explicitly mention tests in the build and test stage.

@jwnimmer-tri
Copy link
Contributor

One easy way to cross-check would be to introduce a failure or bug into one of the test cases, and confirm CI shows red.

@nicolecheetham
Copy link
Collaborator Author

I created a branch with the most recent commit from main being "Add some missing semicolons PR 294" that was commited Jun 25. For context, I made my first commit to this repo Aug 21st.

The catkin installed job had the same warning as what was introduced in PR 328. As such, the catkin tests that require gtest were already skipped when the refactoring started taking place.

Here is the warning below:

CMake Warning at /usr/share/catkin/cmake/test/gtest.cmake:159 (message):
  skipping gtest 'drake_catkin_installed_test' in project
  'drake_catkin_installed' because gtest was not found
Call Stack (most recent call first):
  /usr/share/catkin/cmake/test/gtest.cmake:89 (_catkin_add_executable_with_google_test)
  /usr/share/catkin/cmake/test/gtest.cmake:37 (_catkin_add_google_test)
  drake_catkin_installed/CMakeLists.txt:[54](https://github.com/RobotLocomotion/drake-external-examples/actions/runs/11486269912/job/31968186715?pr=330#step:5:55) (catkin_add_gtest)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants